Clarify that validate and automated skill-review are necessary but not sufficient for skill and risky guidance changes. Add the requirement consistently to contributing guidance, the quality bar, and the PR checklist so maintainers explicitly review logic, safety, failure modes, and risk labeling before merge.
1.9 KiB
1.9 KiB
Pull Request Description
Please include a summary of the change and which skill is added or fixed.
Change Classification
- Skill PR
- Docs PR
- Infra PR
Issue Link (Optional)
Use this only when the PR should auto-close an issue:
Closes #N or Fixes #N
Quality Bar Checklist ✅
All applicable items must be checked before merging.
- Standards: I have read
docs/contributors/quality-bar.mdanddocs/contributors/security-guardrails.md. - Metadata: The
SKILL.mdfrontmatter is valid (checked withnpm run validate). - Risk Label: I have assigned the correct
risk:tag (none,safe,critical,offensive, orunknownfor legacy/unclassified content). - Triggers: The "When to use" section is clear and specific.
- Security: If this is an offensive skill, I included the "Authorized Use Only" disclaimer.
- Safety scan: If this PR adds or modifies
SKILL.mdcommand guidance, remote/network examples, or token-like strings, I rannpm run security:docs(or equivalent hardening check) and addressed any findings. - Automated Skill Review: If this PR changes
SKILL.md, I checked theskill-reviewGitHub Actions result and addressed any actionable feedback. - Manual Logic Review: If this PR changes
SKILL.mdor risky guidance, I manually reviewed the logic, safety, failure modes, andrisk:label instead of relying on automated checks alone. - Local Test: I have verified the skill works locally.
- Repo Checks: I ran
npm run validate:referencesif my change affected docs, workflows, or infrastructure. - Source-Only PR: I did not manually include generated registry artifacts (
CATALOG.md,skills_index.json,data/*.json) in this PR. - Credits: I have added the source credit in
README.md(if applicable). - Maintainer Edits: I enabled Allow edits from maintainers on the PR.