From ad727f18644f4c318697da70dc837acd05997e45 Mon Sep 17 00:00:00 2001 From: voidborne-d Date: Tue, 10 Mar 2026 11:06:19 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20address=20review=20=E2=80=94=20fail=20on?= =?UTF-8?q?=20unknown/error=20verdicts,=20capture=20exit=20code,=20add=20e?= =?UTF-8?q?ngineering-team=20paths?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - catch-all (*) in verdict case now sets OVERALL_EXIT=1 so auditor crashes/errors block merge instead of silently passing - replace '|| true' with '&& EXIT_CODE=$? || EXIT_CODE=$?' to correctly capture auditor exit code - add 'engineering-team/**' to workflow trigger paths (38 skills) --- .github/workflows/skill-security-audit.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/skill-security-audit.yml b/.github/workflows/skill-security-audit.yml index dc7147c..1f7cf7a 100644 --- a/.github/workflows/skill-security-audit.yml +++ b/.github/workflows/skill-security-audit.yml @@ -6,6 +6,7 @@ name: Skill Security Audit types: [opened, synchronize, reopened] paths: - 'engineering/**' + - 'engineering-team/**' - 'business-growth/**' - 'c-level-advisor/**' - 'documentation/**' @@ -120,8 +121,7 @@ jobs: echo "Scanning: $skill_dir" # Run auditor in strict mode with JSON output - JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) || true - EXIT_CODE=$? + JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) && EXIT_CODE=$? || EXIT_CODE=$? # Try to parse JSON output VERDICT=$(echo "$JSON_OUT" | python3 -c " @@ -145,7 +145,7 @@ jobs: PASS) ICON="✅" ;; WARN) ICON="⚠️" ;; FAIL) ICON="❌"; OVERALL_EXIT=1 ;; - *) ICON="❓" ;; + *) ICON="❓"; OVERALL_EXIT=1 ;; esac echo "### $ICON \`$skill_dir\` — $V" >> "$REPORT_FILE"