From e201f349dbc4d2883045b312ecb4897f3f114d40 Mon Sep 17 00:00:00 2001 From: Reza Rezvani Date: Wed, 25 Mar 2026 14:27:02 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20resolve=20audit=20issues=20=E2=80=94=20a?= =?UTF-8?q?dd=20missing=20sections,=20normalize=20frontmatter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - gcp-cloud-architect: add Anti-Patterns table (7 items) + Cross-References - azure-cloud-architect: add Cross-References section - tdd-guide: remove non-standard `triggers:` field from frontmatter Co-Authored-By: Claude Opus 4.6 (1M context) --- .../azure-cloud-architect/SKILL.md | 12 +++++++++ engineering-team/gcp-cloud-architect/SKILL.md | 26 +++++++++++++++++++ engineering-team/tdd-guide/SKILL.md | 11 +------- 3 files changed, 39 insertions(+), 10 deletions(-) diff --git a/engineering-team/azure-cloud-architect/SKILL.md b/engineering-team/azure-cloud-architect/SKILL.md index 732d366..cf981d1 100644 --- a/engineering-team/azure-cloud-architect/SKILL.md +++ b/engineering-team/azure-cloud-architect/SKILL.md @@ -442,6 +442,18 @@ Provide these details for architecture design: --- +## Cross-References + +| Skill | Relationship | +|-------|-------------| +| `engineering-team/aws-solution-architect` | AWS equivalent — same 6-step workflow, different services | +| `engineering-team/gcp-cloud-architect` | GCP equivalent — completes the cloud trifecta | +| `engineering-team/senior-devops` | Broader DevOps scope — pipelines, monitoring, containerization | +| `engineering/terraform-patterns` | IaC implementation — use for Terraform modules targeting Azure | +| `engineering/ci-cd-pipeline-builder` | Pipeline construction — automates Azure DevOps and GitHub Actions | + +--- + ## Reference Documentation | Document | Contents | diff --git a/engineering-team/gcp-cloud-architect/SKILL.md b/engineering-team/gcp-cloud-architect/SKILL.md index 09c26bc..78fc780 100644 --- a/engineering-team/gcp-cloud-architect/SKILL.md +++ b/engineering-team/gcp-cloud-architect/SKILL.md @@ -409,6 +409,32 @@ Provide these details for architecture design: --- +## Anti-Patterns + +| Anti-Pattern | Why It Fails | Better Approach | +|---|---|---| +| Using default VPC for production | No isolation, shared firewall rules | Create custom VPC with private subnets | +| Over-provisioning GKE node pools | Wasted cost on idle capacity | Use GKE Autopilot or cluster autoscaler | +| Storing secrets in environment variables | Visible in Cloud Console, logs | Use Secret Manager with Workload Identity | +| Ignoring sustained use discounts | Missing 20-30% automatic savings | Right-size VMs for consistent baseline usage | +| Single-region deployment for SaaS | One region outage = full downtime | Multi-region with Cloud Load Balancing | +| BigQuery on-demand for heavy workloads | Unpredictable costs at scale | Use BigQuery slots (flat-rate) for consistent workloads | +| Running Cloud Functions for long tasks | 9-minute timeout, cold starts | Use Cloud Run for tasks > 60 seconds | + +--- + +## Cross-References + +| Skill | Relationship | +|-------|-------------| +| `engineering-team/aws-solution-architect` | AWS equivalent — same 6-step workflow, different services | +| `engineering-team/azure-cloud-architect` | Azure equivalent — completes the cloud trifecta | +| `engineering-team/senior-devops` | Broader DevOps scope — pipelines, monitoring, containerization | +| `engineering/terraform-patterns` | IaC implementation — use for Terraform modules targeting GCP | +| `engineering/ci-cd-pipeline-builder` | Pipeline construction — automates Cloud Build and deployment | + +--- + ## Reference Documentation | Document | Contents | diff --git a/engineering-team/tdd-guide/SKILL.md b/engineering-team/tdd-guide/SKILL.md index ea55066..ae28ee0 100644 --- a/engineering-team/tdd-guide/SKILL.md +++ b/engineering-team/tdd-guide/SKILL.md @@ -1,15 +1,6 @@ --- name: "tdd-guide" -description: "Test-driven development skill for writing unit tests, generating test fixtures and mocks, analyzing coverage gaps, and guiding red-green-refactor workflows across Jest, Pytest, JUnit, Vitest, and Mocha. Use when the user asks to write tests, improve test coverage, practice TDD, generate mocks or stubs, or mentions testing frameworks like Jest, pytest, or JUnit. Handles test generation from source code, coverage report parsing (LCOV/JSON/XML), quality scoring, and framework conversion for TypeScript, JavaScript, Python, and Java projects." -triggers: - - generate tests - - analyze coverage - - TDD workflow - - red green refactor - - Jest tests - - Pytest tests - - JUnit tests - - coverage report +description: "Test-driven development skill for writing unit tests, generating test fixtures and mocks, analyzing coverage gaps, and guiding red-green-refactor workflows across Jest, Pytest, JUnit, Vitest, and Mocha. Use when the user asks to write tests, improve test coverage, practice TDD, generate mocks or stubs, or mentions testing frameworks like Jest, pytest, or JUnit." --- # TDD Guide