fix(skill): rewrite senior-security with real security engineering content (#87) (#168)
PROBLEM: Issue #87 feedback - senior-security scored 40/100
- Placeholder reference files with template content only
- Generic scripts without actual security functionality
- Missing trigger phrases, no TOC, no validation workflows
SOLUTION: Complete rewrite with comprehensive security content
SKILL.md (210→436 lines):
- Added 12 triggers: security architecture, threat modeling, STRIDE analysis,
penetration testing, vulnerability assessment, secure coding, OWASP, etc.
- Added TOC with 7 sections
- 5 numbered workflows with validation checkpoints:
1. Threat Modeling (STRIDE methodology)
2. Security Architecture (Zero Trust, Defense-in-Depth)
3. Vulnerability Assessment (OWASP Top 10 mapping)
4. Secure Code Review (checklist with risk categories)
5. Incident Response (severity levels, response phases)
- Added STRIDE per element matrix, DREAD scoring, severity matrices
- Authentication pattern selection guide
- Security tools reference (SAST, DAST, dependency scanning)
- Cryptographic algorithm selection guide
- Compliance frameworks reference (OWASP ASVS, CIS, NIST, PCI-DSS)
- Security headers checklist
References (rebuilt from scratch):
- security-architecture-patterns.md (~615 lines): Zero Trust implementation,
Defense-in-Depth layers, OAuth 2.0 + PKCE flows, JWT patterns, API security
- threat-modeling-guide.md (~518 lines): STRIDE framework with element matrix,
attack trees with probability calculations, DREAD scoring, DFD creation
- cryptography-implementation.md (~775 lines): AES-256-GCM, ChaCha20-Poly1305,
envelope encryption, RSA, Ed25519 signatures, X25519 key exchange, Argon2id
password hashing, key management strategies
Scripts (rebuilt with real functionality):
- threat_modeler.py (~675 lines): Interactive STRIDE analysis for any system
component, DREAD risk scoring, comprehensive threat database with 70+ threats,
mitigation recommendations, JSON/text output
- secret_scanner.py (~516 lines): Detects AWS/GCP/Azure credentials, GitHub/Slack/
Stripe tokens, private keys (RSA/EC/OpenSSH/PGP), generic API keys, database
connection strings, 20+ secret patterns, CI/CD integration ready
Deleted placeholder files:
- references/cryptography_implementation.md (template)
- references/penetration_testing_guide.md (template)
- references/security_architecture_patterns.md (template)
- scripts/pentest_automator.py (placeholder)
- scripts/security_auditor.py (placeholder)
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
5e1f6955e8