v1.0.5: Fix console path — was never fetching from Discord
Console /rules hit early return before DIAG logs and before any Discord fetch. Now fetches async like the player path. DIAG logs moved before the player/console branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
b4fbfc6adf
commit
98f4f5b82a
@@ -0,0 +1,18 @@
|
||||
# Response: DIAG lines missing — console path early exit
|
||||
|
||||
**Re:** Follow-up on REQ-2026-04-13-rules-still-returning-defaults
|
||||
**Date:** 2026-04-13
|
||||
|
||||
## Root Cause
|
||||
The DIAG logs were placed AFTER the console/player branch (line 23). The console path exits on line 18-20 — before DIAG ever runs.
|
||||
|
||||
More importantly: the console path NEVER fetched from Discord. It only returned `RulesCache.getRules()` which is the hardcoded fallback (no fetch has ever populated the cache).
|
||||
|
||||
## Fix in v1.0.5
|
||||
1. Moved DIAG logging before the branch — fires on every /rules invocation
|
||||
2. Console path now triggers `DiscordFetcher.fetchRulesAsync()` just like the player path
|
||||
3. Console output is sent async after fetch completes
|
||||
|
||||
## Deploy
|
||||
firefrostrules-1.0.5-1.20.1-forge.jar → Otherworld.
|
||||
Run /rules from console — should see [DIAG] lines AND a real Discord fetch attempt.
|
||||
Reference in New Issue
Block a user