From d77e35a4a1e93aa33238869138122ba80f9df18e Mon Sep 17 00:00:00 2001
From: Claude Chronicler #88 <claude@firefrostgaming.com>
Date: Tue, 14 Apr 2026 15:56:45 +0000
Subject: [PATCH] =?UTF-8?q?fix:=20EJS=20syntax=20error=20in=20matrix=20bod?=
 =?UTF-8?q?y=20=E2=80=94=20replace=20inline=20onclick=20with=20helper=20fu?=
 =?UTF-8?q?nctions?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../src/views/admin/servers/_matrix_body.ejs          |  8 ++++----
 .../arbiter-3.0/src/views/admin/servers/index.ejs     | 11 ++++++++++-
 2 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/services/arbiter-3.0/src/views/admin/servers/_matrix_body.ejs b/services/arbiter-3.0/src/views/admin/servers/_matrix_body.ejs
index a369f3a..0fc1e70 100644
--- a/services/arbiter-3.0/src/views/admin/servers/_matrix_body.ejs
+++ b/services/arbiter-3.0/src/views/admin/servers/_matrix_body.ejs
@@ -203,7 +203,7 @@
                 <%= (config && config.current_version) ? config.current_version : 'Not set' %>
             </span>
             <button id="version-edit-btn-<%= server.identifier %>"
-                    onclick="document.getElementById('version-form-<%= server.identifier %>').style.display='block';this.style.display='none'"
+                    onclick="toggleVersionForm('<%= server.identifier %>')"
                     style="font-size:10px;background:#333;border:1px solid #555;color:#aaa;padding:2px 8px;border-radius:4px;cursor:pointer;">
                 ✏️ Edit
             </button>
@@ -215,7 +215,7 @@
                        style="font-size:12px;background:#1a1a1a;border:1px solid #555;color:#e0e0e0;padding:4px 8px;border-radius:4px;width:140px;" />
                 <button onclick="saveVersion('<%= server.identifier %>')"
                         style="font-size:11px;background:#2563eb;color:#fff;border:none;padding:4px 10px;border-radius:4px;cursor:pointer;">Save</button>
-                <button onclick="document.getElementById('version-form-<%= server.identifier %>').style.display='none';document.getElementById('version-edit-btn-<%= server.identifier %>').style.display='inline'"
+                <button onclick="hideVersionForm('<%= server.identifier %>')"
                         style="font-size:11px;background:#333;border:1px solid #555;color:#aaa;padding:4px 8px;border-radius:4px;cursor:pointer;">Cancel</button>
             </div>
             <div id="version-result-<%= server.identifier %>" style="margin-top:4px;font-size:11px;"></div>
@@ -437,7 +437,7 @@
                 <%= (config && config.current_version) ? config.current_version : 'Not set' %>
             </span>
             <button id="version-edit-btn-<%= server.identifier %>"
-                    onclick="document.getElementById('version-form-<%= server.identifier %>').style.display='block';this.style.display='none'"
+                    onclick="toggleVersionForm('<%= server.identifier %>')"
                     style="font-size:10px;background:#333;border:1px solid #555;color:#aaa;padding:2px 8px;border-radius:4px;cursor:pointer;">
                 ✏️ Edit
             </button>
@@ -449,7 +449,7 @@
                        style="font-size:12px;background:#1a1a1a;border:1px solid #555;color:#e0e0e0;padding:4px 8px;border-radius:4px;width:140px;" />
                 <button onclick="saveVersion('<%= server.identifier %>')"
                         style="font-size:11px;background:#2563eb;color:#fff;border:none;padding:4px 10px;border-radius:4px;cursor:pointer;">Save</button>
-                <button onclick="document.getElementById('version-form-<%= server.identifier %>').style.display='none';document.getElementById('version-edit-btn-<%= server.identifier %>').style.display='inline'"
+                <button onclick="hideVersionForm('<%= server.identifier %>')"
                         style="font-size:11px;background:#333;border:1px solid #555;color:#aaa;padding:4px 8px;border-radius:4px;cursor:pointer;">Cancel</button>
             </div>
             <div id="version-result-<%= server.identifier %>" style="margin-top:4px;font-size:11px;"></div>
diff --git a/services/arbiter-3.0/src/views/admin/servers/index.ejs b/services/arbiter-3.0/src/views/admin/servers/index.ejs
index 164bcc6..6073f0d 100644
--- a/services/arbiter-3.0/src/views/admin/servers/index.ejs
+++ b/services/arbiter-3.0/src/views/admin/servers/index.ejs
@@ -55,7 +55,6 @@ async function saveVersion(identifier) {
         const text = await res.text();
         result.innerHTML = text;
 
-        // Update the display
         if (res.ok) {
             const display = document.getElementById('version-display-' + identifier);
             const span = display.querySelector('span');
@@ -66,4 +65,14 @@ async function saveVersion(identifier) {
         result.innerHTML = '<span style="color:#ef4444">❌ Failed to save</span>';
     }
 }
+
+function toggleVersionForm(identifier) {
+    document.getElementById('version-form-' + identifier).style.display = 'block';
+    document.getElementById('version-edit-btn-' + identifier).style.display = 'none';
+}
+
+function hideVersionForm(identifier) {
+    document.getElementById('version-form-' + identifier).style.display = 'none';
+    document.getElementById('version-edit-btn-' + identifier).style.display = 'inline';
+}
 </script>