From 414519b3c70c3cb95a075b97c11467c5f53cc745 Mon Sep 17 00:00:00 2001 From: yusyus Date: Sat, 29 Nov 2025 22:01:38 +0300 Subject: [PATCH] fix: Initialize logger before use in github_scraper.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes Issue #190 - "name 'logger' is not defined" error **Problem:** - Logger was used at line 40 (in code_analyzer import exception) - Logger was defined at line 47 - Caused runtime error when code_analyzer import failed **Solution:** - Moved logging.basicConfig() and logger initialization to lines 34-39 - Now logger is defined BEFORE the code_analyzer import block - Warning message now works correctly when code_analyzer is missing **Testing:** - ✅ All 22 GitHub scraper tests pass - ✅ Logger warning appears correctly when code_analyzer missing - ✅ No similar issues found in other CLI files Closes #190 --- src/skill_seekers/cli/github_scraper.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/skill_seekers/cli/github_scraper.py b/src/skill_seekers/cli/github_scraper.py index 7a59253..67a38f3 100644 --- a/src/skill_seekers/cli/github_scraper.py +++ b/src/skill_seekers/cli/github_scraper.py @@ -31,6 +31,13 @@ except ImportError: print("Error: PyGithub not installed. Run: pip install PyGithub") sys.exit(1) +# Configure logging FIRST (before using logger) +logging.basicConfig( + level=logging.INFO, + format='%(asctime)s - %(levelname)s - %(message)s' +) +logger = logging.getLogger(__name__) + # Import code analyzer for deep code analysis try: from .code_analyzer import CodeAnalyzer @@ -39,13 +46,6 @@ except ImportError: CODE_ANALYZER_AVAILABLE = False logger.warning("Code analyzer not available - deep analysis disabled") -# Configure logging -logging.basicConfig( - level=logging.INFO, - format='%(asctime)s - %(levelname)s - %(message)s' -) -logger = logging.getLogger(__name__) - class GitHubScraper: """