fix: Resolve remaining 188 linting errors (249 total fixed)
Second batch of comprehensive linting fixes: Unused Arguments/Variables (136 errors): - ARG002/ARG001 (91 errors): Prefixed unused method/function arguments with '_' - Interface methods in adaptors (base.py, gemini.py, markdown.py) - AST analyzer methods maintaining signatures (code_analyzer.py) - Test fixtures and hooks (conftest.py) - Added noqa: ARG001/ARG002 for pytest hooks requiring exact names - F841 (45 errors): Prefixed unused local variables with '_' - Tuple unpacking where some values aren't needed - Variables assigned but not referenced Loop & Boolean Quality (28 errors): - B007 (18 errors): Prefixed unused loop control variables with '_' - enumerate() loops where index not used - for-in loops where loop variable not referenced - E712 (10 errors): Simplified boolean comparisons - Changed '== True' to direct boolean check - Changed '== False' to 'not' expression - Improved test readability Code Quality (24 errors): - SIM201 (4 errors): Already fixed in previous commit - SIM118 (2 errors): Already fixed in previous commit - E741 (4 errors): Already fixed in previous commit - Config manager loop variable fix (1 error) All Tests Passing: - test_scraper_features.py: 42 passed - test_integration.py: 51 passed - test_architecture_scenarios.py: 11 passed - test_real_world_fastmcp.py: 19 passed, 1 skipped Note: Some SIM errors (nested if, multiple with) remain unfixed as they would require non-trivial refactoring. Focus was on functional correctness. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -146,7 +146,7 @@ class RouterGenerator:
|
||||
|
||||
return routing
|
||||
|
||||
def _extract_skill_specific_labels(self, skill_name: str, skill_keywords: set) -> list[str]:
|
||||
def _extract_skill_specific_labels(self, _skill_name: str, skill_keywords: set) -> list[str]:
|
||||
"""
|
||||
Extract labels from GitHub issues that match this specific skill.
|
||||
|
||||
@@ -198,7 +198,7 @@ class RouterGenerator:
|
||||
|
||||
return list(matching_labels)
|
||||
|
||||
def _generate_frontmatter(self, routing_keywords: dict[str, list[str]]) -> str:
|
||||
def _generate_frontmatter(self, _routing_keywords: dict[str, list[str]]) -> str:
|
||||
"""
|
||||
Generate YAML frontmatter compliant with agentskills.io spec.
|
||||
|
||||
@@ -924,7 +924,7 @@ Simply ask your question and mention the topic. The router will find the right s
|
||||
|
||||
return skill_md
|
||||
|
||||
def generate_subskill_issues_section(self, skill_name: str, topics: list[str]) -> str:
|
||||
def generate_subskill_issues_section(self, _skill_name: str, topics: list[str]) -> str:
|
||||
"""
|
||||
Generate "Common Issues" section for a sub-skill (Phase 4).
|
||||
|
||||
|
||||
Reference in New Issue
Block a user