firefrost-gaming/skill-seekers-reference
3
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

run ruff

Browse Source
This commit is contained in:
Pablo Estevez
2026-01-17 17:29:21 +00:00
parent c89f059712
commit 5ed767ff9a
144 changed files with 14142 additions and 16488 deletions
Download Patch File Download Diff File Expand all files Collapse all files

177
src/skill_seekers/cli/config_validator.py
View File

@@ -12,8 +12,8 @@ Also provides backward compatibility detection for legacy configs.
import json
import logging
from typing import Dict, Any, List, Optional, Union
from pathlib import Path
from typing import Any
logging.basicConfig(level=logging.INFO)
logger = logging.getLogger(__name__)
@@ -25,18 +25,18 @@ class ConfigValidator:
"""
# Valid source types
VALID_SOURCE_TYPES = {'documentation', 'github', 'pdf'}
VALID_SOURCE_TYPES = {"documentation", "github", "pdf"}
# Valid merge modes
VALID_MERGE_MODES = {'rule-based', 'claude-enhanced'}
VALID_MERGE_MODES = {"rule-based", "claude-enhanced"}
# Valid code analysis depth levels
VALID_DEPTH_LEVELS = {'surface', 'deep', 'full'}
VALID_DEPTH_LEVELS = {"surface", "deep", "full"}
# Valid AI modes for C3.x enhancement
VALID_AI_MODES = {'auto', 'api', 'local', 'none'}
VALID_AI_MODES = {"auto", "api", "local", "none"}
def __init__(self, config_or_path: Union[Dict[str, Any], str]):
def __init__(self, config_or_path: dict[str, Any] | str):
"""
Initialize validator with config dict or file path.
@@ -51,10 +51,10 @@ class ConfigValidator:
self.config = self._load_config()
self.is_unified = self._detect_format()
def _load_config(self) -> Dict[str, Any]:
def _load_config(self) -> dict[str, Any]:
"""Load JSON config file."""
try:
with open(self.config_path, 'r', encoding='utf-8') as f:
with open(self.config_path, encoding="utf-8") as f:
return json.load(f)
except FileNotFoundError:
raise ValueError(f"Config file not found: {self.config_path}")
@@ -69,7 +69,7 @@ class ConfigValidator:
True if unified format (has 'sources' array)
False if legacy format
"""
return 'sources' in self.config and isinstance(self.config['sources'], list)
return "sources" in self.config and isinstance(self.config["sources"], list)
def validate(self) -> bool:
"""
@@ -91,17 +91,17 @@ class ConfigValidator:
logger.info("Validating unified config format...")
# Required top-level fields
if 'name' not in self.config:
if "name" not in self.config:
raise ValueError("Missing required field: 'name'")
if 'description' not in self.config:
if "description" not in self.config:
raise ValueError("Missing required field: 'description'")
if 'sources' not in self.config:
if "sources" not in self.config:
raise ValueError("Missing required field: 'sources'")
# Validate sources array
sources = self.config['sources']
sources = self.config["sources"]
if not isinstance(sources, list):
raise ValueError("'sources' must be an array")
@@ -110,7 +110,7 @@ class ConfigValidator:
raise ValueError("'sources' array cannot be empty")
# Validate merge_mode (optional)
merge_mode = self.config.get('merge_mode', 'rule-based')
merge_mode = self.config.get("merge_mode", "rule-based")
if merge_mode not in self.VALID_MERGE_MODES:
raise ValueError(f"Invalid merge_mode: '{merge_mode}'. Must be one of {self.VALID_MERGE_MODES}")
@@ -121,56 +121,52 @@ class ConfigValidator:
logger.info(f"✅ Unified config valid: {len(sources)} sources")
return True
def _validate_source(self, source: Dict[str, Any], index: int):
def _validate_source(self, source: dict[str, Any], index: int):
"""Validate individual source configuration."""
# Check source has 'type' field
if 'type' not in source:
if "type" not in source:
raise ValueError(f"Source {index}: Missing required field 'type'")
source_type = source['type']
source_type = source["type"]
if source_type not in self.VALID_SOURCE_TYPES:
raise ValueError(
f"Source {index}: Invalid type '{source_type}'. "
f"Must be one of {self.VALID_SOURCE_TYPES}"
)
raise ValueError(f"Source {index}: Invalid type '{source_type}'. Must be one of {self.VALID_SOURCE_TYPES}")
# Type-specific validation
if source_type == 'documentation':
if source_type == "documentation":
self._validate_documentation_source(source, index)
elif source_type == 'github':
elif source_type == "github":
self._validate_github_source(source, index)
elif source_type == 'pdf':
elif source_type == "pdf":
self._validate_pdf_source(source, index)
def _validate_documentation_source(self, source: Dict[str, Any], index: int):
def _validate_documentation_source(self, source: dict[str, Any], index: int):
"""Validate documentation source configuration."""
if 'base_url' not in source:
if "base_url" not in source:
raise ValueError(f"Source {index} (documentation): Missing required field 'base_url'")
# Optional but recommended fields
if 'selectors' not in source:
if "selectors" not in source:
logger.warning(f"Source {index} (documentation): No 'selectors' specified, using defaults")
if 'max_pages' in source and not isinstance(source['max_pages'], int):
if "max_pages" in source and not isinstance(source["max_pages"], int):
raise ValueError(f"Source {index} (documentation): 'max_pages' must be an integer")
def _validate_github_source(self, source: Dict[str, Any], index: int):
def _validate_github_source(self, source: dict[str, Any], index: int):
"""Validate GitHub source configuration."""
if 'repo' not in source:
if "repo" not in source:
raise ValueError(f"Source {index} (github): Missing required field 'repo'")
# Validate repo format (owner/repo)
repo = source['repo']
if '/' not in repo:
repo = source["repo"]
if "/" not in repo:
raise ValueError(
f"Source {index} (github): Invalid repo format '{repo}'. "
f"Must be 'owner/repo' (e.g., 'facebook/react')"
f"Source {index} (github): Invalid repo format '{repo}'. Must be 'owner/repo' (e.g., 'facebook/react')"
)
# Validate code_analysis_depth if specified
if 'code_analysis_depth' in source:
depth = source['code_analysis_depth']
if "code_analysis_depth" in source:
depth = source["code_analysis_depth"]
if depth not in self.VALID_DEPTH_LEVELS:
raise ValueError(
f"Source {index} (github): Invalid code_analysis_depth '{depth}'. "
@@ -178,29 +174,28 @@ class ConfigValidator:
)
# Validate max_issues if specified
if 'max_issues' in source and not isinstance(source['max_issues'], int):
if "max_issues" in source and not isinstance(source["max_issues"], int):
raise ValueError(f"Source {index} (github): 'max_issues' must be an integer")
# Validate enable_codebase_analysis if specified (C3.5)
if 'enable_codebase_analysis' in source and not isinstance(source['enable_codebase_analysis'], bool):
if "enable_codebase_analysis" in source and not isinstance(source["enable_codebase_analysis"], bool):
raise ValueError(f"Source {index} (github): 'enable_codebase_analysis' must be a boolean")
# Validate ai_mode if specified (C3.5)
if 'ai_mode' in source:
ai_mode = source['ai_mode']
if "ai_mode" in source:
ai_mode = source["ai_mode"]
if ai_mode not in self.VALID_AI_MODES:
raise ValueError(
f"Source {index} (github): Invalid ai_mode '{ai_mode}'. "
f"Must be one of {self.VALID_AI_MODES}"
f"Source {index} (github): Invalid ai_mode '{ai_mode}'. Must be one of {self.VALID_AI_MODES}"
)
def _validate_pdf_source(self, source: Dict[str, Any], index: int):
def _validate_pdf_source(self, source: dict[str, Any], index: int):
"""Validate PDF source configuration."""
if 'path' not in source:
if "path" not in source:
raise ValueError(f"Source {index} (pdf): Missing required field 'path'")
# Check if file exists
pdf_path = source['path']
pdf_path = source["path"]
if not Path(pdf_path).exists():
logger.warning(f"Source {index} (pdf): File not found: {pdf_path}")
@@ -213,18 +208,18 @@ class ConfigValidator:
logger.info("Detected legacy config format (backward compatible)")
# Detect which legacy type based on fields
if 'base_url' in self.config:
if "base_url" in self.config:
logger.info("Legacy type: documentation")
elif 'repo' in self.config:
elif "repo" in self.config:
logger.info("Legacy type: github")
elif 'pdf' in self.config or 'path' in self.config:
elif "pdf" in self.config or "path" in self.config:
logger.info("Legacy type: pdf")
else:
raise ValueError("Cannot detect legacy config type (missing base_url, repo, or pdf)")
return True
def convert_legacy_to_unified(self) -> Dict[str, Any]:
def convert_legacy_to_unified(self) -> dict[str, Any]:
"""
Convert legacy config to unified format.
@@ -238,64 +233,50 @@ class ConfigValidator:
logger.info("Converting legacy config to unified format...")
# Detect legacy type and convert
if 'base_url' in self.config:
if "base_url" in self.config:
return self._convert_legacy_documentation()
elif 'repo' in self.config:
elif "repo" in self.config:
return self._convert_legacy_github()
elif 'pdf' in self.config or 'path' in self.config:
elif "pdf" in self.config or "path" in self.config:
return self._convert_legacy_pdf()
else:
raise ValueError("Cannot convert: unknown legacy format")
def _convert_legacy_documentation(self) -> Dict[str, Any]:
def _convert_legacy_documentation(self) -> dict[str, Any]:
"""Convert legacy documentation config to unified."""
unified = {
'name': self.config.get('name', 'unnamed'),
'description': self.config.get('description', 'Documentation skill'),
'merge_mode': 'rule-based',
'sources': [
{
'type': 'documentation',
**{k: v for k, v in self.config.items()
if k not in ['name', 'description']}
}
]
"name": self.config.get("name", "unnamed"),
"description": self.config.get("description", "Documentation skill"),
"merge_mode": "rule-based",
"sources": [
{"type": "documentation", **{k: v for k, v in self.config.items() if k not in ["name", "description"]}}
],
}
return unified
def _convert_legacy_github(self) -> Dict[str, Any]:
def _convert_legacy_github(self) -> dict[str, Any]:
"""Convert legacy GitHub config to unified."""
unified = {
'name': self.config.get('name', 'unnamed'),
'description': self.config.get('description', 'GitHub repository skill'),
'merge_mode': 'rule-based',
'sources': [
{
'type': 'github',
**{k: v for k, v in self.config.items()
if k not in ['name', 'description']}
}
]
"name": self.config.get("name", "unnamed"),
"description": self.config.get("description", "GitHub repository skill"),
"merge_mode": "rule-based",
"sources": [
{"type": "github", **{k: v for k, v in self.config.items() if k not in ["name", "description"]}}
],
}
return unified
def _convert_legacy_pdf(self) -> Dict[str, Any]:
def _convert_legacy_pdf(self) -> dict[str, Any]:
"""Convert legacy PDF config to unified."""
unified = {
'name': self.config.get('name', 'unnamed'),
'description': self.config.get('description', 'PDF document skill'),
'merge_mode': 'rule-based',
'sources': [
{
'type': 'pdf',
**{k: v for k, v in self.config.items()
if k not in ['name', 'description']}
}
]
"name": self.config.get("name", "unnamed"),
"description": self.config.get("description", "PDF document skill"),
"merge_mode": "rule-based",
"sources": [{"type": "pdf", **{k: v for k, v in self.config.items() if k not in ["name", "description"]}}],
}
return unified
def get_sources_by_type(self, source_type: str) -> List[Dict[str, Any]]:
def get_sources_by_type(self, source_type: str) -> list[dict[str, Any]]:
"""
Get all sources of a specific type.
@@ -308,17 +289,17 @@ class ConfigValidator:
if not self.is_unified:
# For legacy, convert and get sources
unified = self.convert_legacy_to_unified()
sources = unified['sources']
sources = unified["sources"]
else:
sources = self.config['sources']
sources = self.config["sources"]
return [s for s in sources if s.get('type') == source_type]
return [s for s in sources if s.get("type") == source_type]
def has_multiple_sources(self) -> bool:
"""Check if config has multiple sources (requires merging)."""
if not self.is_unified:
return False
return len(self.config['sources']) > 1
return len(self.config["sources"]) > 1
def needs_api_merge(self) -> bool:
"""
@@ -331,13 +312,11 @@ class ConfigValidator:
return False
has_docs_api = any(
s.get('type') == 'documentation' and s.get('extract_api', True)
for s in self.config['sources']
s.get("type") == "documentation" and s.get("extract_api", True) for s in self.config["sources"]
)
has_github_code = any(
s.get('type') == 'github' and s.get('include_code', False)
for s in self.config['sources']
s.get("type") == "github" and s.get("include_code", False) for s in self.config["sources"]
)
return has_docs_api and has_github_code
@@ -361,7 +340,7 @@ def validate_config(config_path: str) -> ConfigValidator:
return validator
if __name__ == '__main__':
if __name__ == "__main__":
import sys
if len(sys.argv) < 2:
@@ -373,18 +352,18 @@ if __name__ == '__main__':
try:
validator = validate_config(config_file)
print(f"\n✅ Config valid!")
print("\n✅ Config valid!")
print(f" Format: {'Unified' if validator.is_unified else 'Legacy'}")
print(f" Name: {validator.config.get('name')}")
if validator.is_unified:
sources = validator.config['sources']
sources = validator.config["sources"]
print(f" Sources: {len(sources)}")
for i, source in enumerate(sources):
print(f" {i+1}. {source['type']}")
print(f" {i + 1}. {source['type']}")
if validator.needs_api_merge():
merge_mode = validator.config.get('merge_mode', 'rule-based')
merge_mode = validator.config.get("merge_mode", "rule-based")
print(f" ⚠️ API merge required (mode: {merge_mode})")
except ValueError as e: