firefrost-gaming/skill-seekers-reference
3
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

style: fix ruff lint and formatting errors

Browse Source 
- E741: rename ambiguous variable `l` → `line_text` in enhance_skill_local.py
- ARG001: suppress unused `doc` param in word_scraper _build_section()
- SIM108: use ternary for code_text assignment in word_scraper
- F841: remove unused `metadata` variable in test_chunking_integration
- F401: remove unused imports in test_pinecone_adaptor
- ARG001: rename unused `docs` → `_docs` in test_pinecone_adaptor
- Format 20 files to match ruff formatting rules

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
yusyus
2026-03-01 10:54:32 +03:00
parent 064405c052
commit 6c31990941
7 changed files with 108 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
tests/test_pinecone_adaptor.py
View File

@@ -4,11 +4,10 @@ Tests for Pinecone adaptor and doc_version metadata flow.
"""
import json
from pathlib import Path
import pytest
from skill_seekers.cli.adaptors.base import SkillAdaptor, SkillMetadata
from skill_seekers.cli.adaptors.base import SkillMetadata
# ---------------------------------------------------------------------------
@@ -40,9 +39,7 @@ Get started quickly.
refs_dir = skill_dir / "references"
refs_dir.mkdir()
(refs_dir / "api_reference.md").write_text(
"# API Reference\n\nSome API docs.\n"
)
(refs_dir / "api_reference.md").write_text("# API Reference\n\nSome API docs.\n")
(refs_dir / "getting_started.md").write_text(
"# Getting Started\n\nSome getting started docs.\n"
)
@@ -330,13 +327,17 @@ class TestPineconeAdaptor:
if vectors is None:
vectors = [{"id": "a", "metadata": {"text": "hello world"}}]
pkg = tmp_path / "test-pinecone.json"
pkg.write_text(json.dumps({
"vectors": vectors,
"index_name": "test",
"namespace": "test",
"metric": "cosine",
"dimension": 1536,
}))
pkg.write_text(
json.dumps(
{
"vectors": vectors,
"index_name": "test",
"namespace": "test",
"metric": "cosine",
"dimension": 1536,
}
)
)
return pkg
def test_upload_success_has_url_key(self, tmp_path, monkeypatch):
@@ -346,7 +347,8 @@ class TestPineconeAdaptor:
adaptor = PineconeAdaptor()
mock_pc, _mock_index = self._make_mock_pinecone(monkeypatch)
monkeypatch.setattr(
adaptor, "_generate_openai_embeddings",
adaptor,
"_generate_openai_embeddings",
lambda docs: [[0.0] * 1536] * len(docs),
)
pkg = self._make_package(tmp_path)
@@ -364,13 +366,16 @@ class TestPineconeAdaptor:
adaptor = PineconeAdaptor()
mock_pc, _mock_index = self._make_mock_pinecone(monkeypatch)
monkeypatch.setattr(
adaptor, "_generate_st_embeddings",
adaptor,
"_generate_st_embeddings",
lambda docs: [[0.0] * 384] * len(docs),
)
pkg = self._make_package(tmp_path)
result = adaptor.upload(
pkg, api_key="fake-key", embedding_function="sentence-transformers",
pkg,
api_key="fake-key",
embedding_function="sentence-transformers",
)
assert result["success"] is True
# Verify create_index was called with dimension=384
@@ -385,13 +390,16 @@ class TestPineconeAdaptor:
adaptor = PineconeAdaptor()
mock_pc, _mock_index = self._make_mock_pinecone(monkeypatch)
monkeypatch.setattr(
adaptor, "_generate_openai_embeddings",
adaptor,
"_generate_openai_embeddings",
lambda docs: [[0.0] * 1536] * len(docs),
)
pkg = self._make_package(tmp_path)
result = adaptor.upload(
pkg, api_key="fake-key", embedding_function="openai",
pkg,
api_key="fake-key",
embedding_function="openai",
)
assert result["success"] is True
mock_pc.create_index.assert_called_once()
@@ -405,7 +413,7 @@ class TestPineconeAdaptor:
adaptor = PineconeAdaptor()
mock_pc, _mock_index = self._make_mock_pinecone(monkeypatch)
def fail_embeddings(docs):
def fail_embeddings(_docs):
raise RuntimeError("OPENAI_API_KEY not set")
monkeypatch.setattr(adaptor, "_generate_openai_embeddings", fail_embeddings)
@@ -423,13 +431,17 @@ class TestPineconeAdaptor:
adaptor = PineconeAdaptor()
mock_pc, _mock_index = self._make_mock_pinecone(monkeypatch)
monkeypatch.setattr(
adaptor, "_generate_openai_embeddings",
adaptor,
"_generate_openai_embeddings",
lambda docs: [[0.0] * 768] * len(docs),
)
pkg = self._make_package(tmp_path)
result = adaptor.upload(
pkg, api_key="fake-key", embedding_function="openai", dimension=768,
pkg,
api_key="fake-key",
embedding_function="openai",
dimension=768,
)
assert result["success"] is True
mock_pc.create_index.assert_called_once()