fix: Resolve 21 ruff linting errors (SIM102, SIM117, B904, SIM113, B007)

Fixed all 21 linting errors identified in GitHub Actions:

SIM102 (7 errors - nested if statements):
- config_extractor.py:468 - Combined nested conditions
- config_validator.py (was B904, already fixed)
- pattern_recognizer.py:430,538,916 - Combined nested conditions
- test_example_extractor.py:365,412,460 - Combined nested conditions
- unified_skill_builder.py:1070 - Combined nested conditions

SIM117 (9 errors - multiple with statements):
- test_install_agent.py:418 - Combined with statements
- test_issue_219_e2e.py:278 - Combined with statements
- test_llms_txt_downloader.py:33,88 - Combined with statements
- test_skip_llms_txt.py:75,98,121,148,172,304 - Combined with statements

B904 (1 error - exception handling):
- config_validator.py:62 - Added 'from e' to exception chain

SIM113 (1 error - enumerate usage):
- doc_scraper.py:1068 - Removed unused 'completed' counter variable

B007 (1 error - unused loop variable):
- pdf_scraper.py:167 - Changed 'keywords' to '_' for unused variable

All changes improve code quality without altering functionality.
Tests: 1214 passed, 167 skipped (4 pre-existing failures unrelated)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
yusyus
2026-01-17 23:54:22 +03:00
parent 6439c85cde
commit 9666938eb0
11 changed files with 173 additions and 199 deletions

View File

@@ -275,46 +275,45 @@ class TestIssue219Problem3CustomAPIEndpoints(unittest.TestCase):
except ImportError:
self.skipTest("anthropic package not installed")
with patch.dict(os.environ, {"ANTHROPIC_API_KEY": "test-key"}):
with patch("skill_seekers.cli.enhance_skill.anthropic.Anthropic") as mock_anthropic:
enhancer = SkillEnhancer(self.skill_dir)
with patch.dict(os.environ, {"ANTHROPIC_API_KEY": "test-key"}), patch("skill_seekers.cli.enhance_skill.anthropic.Anthropic") as mock_anthropic:
enhancer = SkillEnhancer(self.skill_dir)
# Mock response with ThinkingBlock (newer SDK)
# ThinkingBlock has no .text attribute
mock_thinking_block = SimpleNamespace(type="thinking")
# Mock response with ThinkingBlock (newer SDK)
# ThinkingBlock has no .text attribute
mock_thinking_block = SimpleNamespace(type="thinking")
# TextBlock has .text attribute
mock_text_block = SimpleNamespace(text="# Enhanced SKILL.md\n\nContent here")
# TextBlock has .text attribute
mock_text_block = SimpleNamespace(text="# Enhanced SKILL.md\n\nContent here")
mock_message = Mock()
mock_message.content = [mock_thinking_block, mock_text_block]
mock_message = Mock()
mock_message.content = [mock_thinking_block, mock_text_block]
mock_client = mock_anthropic.return_value
mock_client.messages.create.return_value = mock_message
mock_client = mock_anthropic.return_value
mock_client.messages.create.return_value = mock_message
# Read references (with proper metadata structure)
references = {
"index.md": {
"content": "# Index\nTest content",
"source": "documentation",
"confidence": "high",
"path": "index.md",
"truncated": False,
"size": 23,
"repo_id": None,
}
# Read references (with proper metadata structure)
references = {
"index.md": {
"content": "# Index\nTest content",
"source": "documentation",
"confidence": "high",
"path": "index.md",
"truncated": False,
"size": 23,
"repo_id": None,
}
}
# Call enhance_skill_md (should handle ThinkingBlock gracefully)
result = enhancer.enhance_skill_md(references, current_skill_md="# Old")
# Call enhance_skill_md (should handle ThinkingBlock gracefully)
result = enhancer.enhance_skill_md(references, current_skill_md="# Old")
# VERIFY: Should find text from TextBlock, ignore ThinkingBlock
self.assertIsNotNone(result, "Should return enhanced content")
self.assertEqual(
result,
"# Enhanced SKILL.md\n\nContent here",
"Should extract text from TextBlock",
)
# VERIFY: Should find text from TextBlock, ignore ThinkingBlock
self.assertIsNotNone(result, "Should return enhanced content")
self.assertEqual(
result,
"# Enhanced SKILL.md\n\nContent here",
"Should extract text from TextBlock",
)
class TestIssue219IntegrationAll(unittest.TestCase):