From ce4d90eea4126c46165ed8ddb13f574b37d292fa Mon Sep 17 00:00:00 2001 From: yusyus Date: Sun, 18 Jan 2026 13:33:32 +0300 Subject: [PATCH] test: Update setup_mcp.sh tests for PR #252 changes Fixed 2 test assertions to match PR #252 improvements: 1. test_requirements_txt_path: - Now accepts '-e ".[mcp]"' format with MCP extra dependencies - Previously only accepted '-e .' format 2. test_json_config_path_format: - Now checks for module reference 'skill_seekers.mcp.server_fastmcp' - Previously checked for file path 'server_fastmcp.py' These changes align tests with the modern module import approach introduced in PR #252 for better venv compatibility. Co-Authored-By: Claude Sonnet 4.5 --- tests/test_setup_scripts.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/test_setup_scripts.py b/tests/test_setup_scripts.py index 322c933..88ee713 100644 --- a/tests/test_setup_scripts.py +++ b/tests/test_setup_scripts.py @@ -62,9 +62,11 @@ class TestSetupMCPScript: def test_requirements_txt_path(self, script_content): """Test that script uses pip install -e . (v2.0.0 modern packaging)""" # v2.0.0 uses '-e .' (editable install) instead of requirements files - # The actual command is "$PIP_INSTALL_CMD -e ." - assert " -e ." in script_content or " -e." in script_content, ( - "Should use '-e .' for editable install (modern packaging)" + # v2.7.0 PR #252 uses '-e ".[mcp]"' with MCP extra dependencies + # The actual command is "$PIP_INSTALL_CMD -e ." or "$PIP_INSTALL_CMD -e ".[mcp]"" + has_editable = " -e ." in script_content or " -e." in script_content or '-e ".' in script_content + assert has_editable, ( + "Should use '-e .' or '-e \".[mcp]\"' for editable install (modern packaging)" ) # Should NOT reference old requirements.txt paths @@ -121,9 +123,10 @@ class TestSetupMCPScript: def test_json_config_path_format(self, script_content): """Test that JSON config examples use correct format (v2.4.0 MCP 2025 upgrade)""" # MCP 2025 uses module import: python3 -m skill_seekers.mcp.server_fastmcp - # Config should show the server_fastmcp.py path for stdio examples - assert "server_fastmcp.py" in script_content, ( - "Config should reference server_fastmcp.py (MCP 2025 upgrade)" + # v2.7.0 PR #252 uses module reference format, not file path + # Config should show the module reference: skill_seekers.mcp.server_fastmcp + assert "skill_seekers.mcp.server_fastmcp" in script_content, ( + "Config should reference skill_seekers.mcp.server_fastmcp module (MCP 2025 upgrade)" ) def test_no_hardcoded_paths(self, script_content):