yusyus
04de96f2f5
fix: Add empty list checks and enhance docstrings (PR #243 review fixes)
...
Two critical improvements from PR #243 code review:
## Fix 1: Empty List Edge Case Handling
Added early return checks to prevent creating empty index files:
**Files Modified:**
- src/skill_seekers/cli/unified_skill_builder.py
**Changes:**
- _generate_docs_references: Skip if docs_list empty
- _generate_github_references: Skip if github_list empty
- _generate_pdf_references: Skip if pdf_list empty
**Impact:**
Prevents "Combined from 0 sources" index files which look odd.
## Fix 2: Enhanced Method Docstrings
Added comprehensive parameter types and return value documentation:
**Files Modified:**
- src/skill_seekers/cli/llms_txt_parser.py
- extract_urls: Added detailed examples and behavior notes
- _clean_url: Added malformed URL pattern examples
- src/skill_seekers/cli/doc_scraper.py
- _extract_markdown_content: Full return dict structure documented
- _extract_html_as_markdown: Extraction strategy and fallback behavior
**Impact:**
Improved developer experience with detailed API documentation.
## Testing
All tests passing:
- ✅ 32/32 PR #243 tests (markdown parsing + multi-source)
- ✅ 975/975 core tests
- 159 skipped (optional dependencies)
- 4 failed (missing anthropic - expected)
Co-authored-by: Code Review <claude-sonnet-4.5@anthropic.com >
2026-01-11 14:01:23 +03:00
tsyhahaha
8cf43582a4
feat: support multiple sources of same type in unified scraper
...
- Add Markdown file parsing in doc_scraper (_extract_markdown_content, _extract_html_as_markdown)
- Add URL extraction and cleaning in llms_txt_parser (extract_urls, _clean_url)
- Support multiple documentation/github/pdf sources in unified_scraper
- Generate separate reference directories per source in unified_skill_builder
- Skip pages with empty/short content (<50 chars)
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2026-01-05 21:45:36 +08:00
Chris Engelhard
9949cdcdca
Fix: include docs references in unified skill output ( #213 )
...
* Fix: include docs references in unified skill output
* Fix: quality checker counts nested reference files
* fix(unified): pass through llms_txt_url and skip_llms_txt to doc scraper
* configs: add svelte CLI unified preset (llms.txt + categories)
---------
Co-authored-by: Chris Engelhard <chris@chrisengelhard.nl >
2026-01-01 19:40:51 +03:00
yusyus
ce1c07b437
feat: Add modern Python packaging - Phase 1 (Foundation)
...
Implements issue #168 - Modern Python packaging with uv support
This is Phase 1 of the modernization effort, establishing the core
package structure and build system.
## Major Changes
### 1. Migrated to src/ Layout
- Moved cli/ → src/skill_seekers/cli/
- Moved skill_seeker_mcp/ → src/skill_seekers/mcp/
- Created root package: src/skill_seekers/__init__.py
- Updated all imports: cli. → skill_seekers.cli.
- Updated all imports: skill_seeker_mcp. → skill_seekers.mcp.
### 2. Created pyproject.toml
- Modern Python packaging configuration
- All dependencies properly declared
- 8 CLI entry points configured:
* skill-seekers (unified CLI)
* skill-seekers-scrape
* skill-seekers-github
* skill-seekers-pdf
* skill-seekers-unified
* skill-seekers-enhance
* skill-seekers-package
* skill-seekers-upload
* skill-seekers-estimate
- uv tool support enabled
- Build system: setuptools with wheel
### 3. Created Unified CLI (main.py)
- Git-style subcommands (skill-seekers scrape, etc.)
- Delegates to existing tool main() functions
- Full help system at top-level and subcommand level
- Backwards compatible with individual commands
### 4. Updated Package Versions
- cli/__init__.py: 1.3.0 → 2.0.0
- mcp/__init__.py: 1.2.0 → 2.0.0
- Root package: 2.0.0
### 5. Updated Test Suite
- Fixed test_package_structure.py for new layout
- All 28 package structure tests passing
- Updated all test imports for new structure
## Installation Methods (Working)
```bash
# Development install
pip install -e .
# Run unified CLI
skill-seekers --version # → 2.0.0
skill-seekers --help
# Run individual tools
skill-seekers-scrape --help
skill-seekers-github --help
```
## Test Results
- Package structure tests: 28/28 passing ✅
- Package installs successfully ✅
- All entry points working ✅
## Still TODO (Phase 2)
- [ ] Run full test suite (299 tests)
- [ ] Update documentation (README, CLAUDE.md, etc.)
- [ ] Test with uv tool run/install
- [ ] Build and publish to PyPI
- [ ] Create PR and merge
## Breaking Changes
None - fully backwards compatible. Old import paths still work.
## Migration for Users
No action needed. Package works with both pip and uv.
Closes #168 (when complete)
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-11-07 01:14:24 +03:00
