yusyus
|
51787e57bc
|
style: Fix 411 ruff lint issues (Kimi's issue #4)
Auto-fixed lint issues with ruff --fix and --unsafe-fixes:
Issue #4: Ruff Lint Issues
- Before: 447 errors (originally reported as ~5,500)
- After: 55 errors remaining
- Fixed: 411 errors (92% reduction)
Auto-fixes applied:
- 156 UP006: List/Dict → list/dict (PEP 585)
- 63 UP045: Optional[X] → X | None (PEP 604)
- 52 F401: Removed unused imports
- 52 UP035: Fixed deprecated imports
- 34 E712: True/False comparisons → not/bool()
- 17 F841: Removed unused variables
- Plus 37 other auto-fixable issues
Remaining 55 errors (non-critical):
- 39 B904: Exception chaining (best practice)
- 5 F401: Unused imports (edge cases)
- 3 SIM105: Could use contextlib.suppress
- 8 other minor style issues
These remaining issues are code quality improvements, not critical bugs.
Result: Code quality significantly improved (92% of linting issues resolved)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
2026-02-08 12:46:38 +03:00 |
|
yusyus
|
4175a3a050
|
test: Add comprehensive E2E tests for all 7 RAG adaptors
Added TestRAGAdaptorsE2E class with 6 comprehensive end-to-end tests covering:
1. test_e2e_all_rag_adaptors_from_same_skill
- Verifies all 7 RAG adaptors (LangChain, LlamaIndex, Haystack, Weaviate,
Chroma, FAISS, Qdrant) can package the same skill
- Validates JSON output format
- Ensures consistent behavior across platforms
2. test_e2e_rag_adaptors_preserve_metadata
- Tests metadata preservation (source, version, author, tags)
- Validates different platform structures (LangChain list, Weaviate schema,
Chroma dict)
- Ensures metadata flows through packaging pipeline
3. test_e2e_rag_json_structure_validation
- Validates JSON structure for each of 7 RAG adaptors
- Ensures required fields present (documents, metadata, IDs, etc.)
- Platform-specific structure validation
4. test_e2e_rag_empty_skill_handling
- Tests graceful handling of empty skill directories
- Verifies empty but valid structures returned
- Prevents crashes on edge cases
5. test_e2e_rag_category_detection
- Verifies category inference from file names
- Tests overview + reference categorization
- Validates across LangChain, Weaviate, and Chroma
6. test_e2e_rag_integration_workflow_chromadb
- Complete workflow test: package → ChromaDB → query → verify
- Tests in-memory ChromaDB integration
- Validates semantic search functionality
- Skipped if chromadb not installed
Results:
- 6 new E2E tests added
- 23 total E2E tests passing
- 1 test skipped (chromadb integration, optional dependency)
- All existing tests still passing (no regressions)
- Test coverage for all RAG adaptors now comprehensive
Phase 3 of optional enhancements complete.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
2026-02-07 22:41:15 +03:00 |
|
yusyus
|
d587240e7b
|
test: Add comprehensive E2E and unit tests for multi-LLM adaptors
Add 37 new tests (all passing):
**E2E Tests (18 tests):**
- test_adaptors_e2e.py - Complete workflow testing
- Test all platforms package from same skill
- Verify package structure for each platform
- Test filename conventions and formats
- Validate metadata consistency
- Test API key validation
- Test error handling (invalid files, missing deps)
**Claude Adaptor Tests (19 tests):**
- test_claude_adaptor.py - Comprehensive Claude adaptor coverage
- Platform info and API key validation
- SKILL.md formatting with YAML frontmatter
- Package creation and structure
- Upload success/failure scenarios
- Custom output paths
- Edge cases (special characters, minimal metadata)
- Network error handling
**Test Results:**
- 694 total tests passing (was 657, +37 new)
- 82 adaptor tests (77 passing, 5 skipped integration)
- 18 E2E workflow tests (all passing)
- 157 tests skipped (unchanged)
- No failures
**Coverage Improvements:**
- Complete workflow validation for all platforms
- Package format verification (ZIP vs tar.gz)
- Metadata consistency checks
- Error path coverage
- API key validation edge cases
All tests run without real API keys (mocked).
Related to #179
|
2025-12-28 20:47:00 +03:00 |
|
