Commit Graph

5 Commits

Author SHA1 Message Date
yusyus
6008f13127 test: Add comprehensive HTML detection tests for llms.txt downloader (PR #244 review fix)
Added 7 test cases to verify HTML redirect trap prevention:
- test_is_markdown_rejects_html_doctype() - DOCTYPE rejection (case-insensitive)
- test_is_markdown_rejects_html_tag() - <html> tag rejection
- test_is_markdown_rejects_html_meta() - <meta> and <head> tag rejection
- test_is_markdown_accepts_markdown_with_html_words() - Edge case: markdown mentioning "html"
- test_html_detection_only_scans_first_500_chars() - Performance optimization verification
- test_html_redirect_trap_scenario() - Real-world Claude Code redirect scenario
- test_download_rejects_html_redirect() - End-to-end download rejection

Addresses minor observation from PR #244 review:
- Ensures HTML detection logic is fully covered
- Prevents regression of redirect trap fixes
- Validates 500-char scanning optimization

Test Results: 20/20 llms_txt_downloader tests passing
Overall: 982/982 tests passing (4 expected failures - missing anthropic package)

Related: PR #244 (Claude Code documentation config update)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-01-11 14:16:44 +03:00
yusyus
ce1c07b437 feat: Add modern Python packaging - Phase 1 (Foundation)
Implements issue #168 - Modern Python packaging with uv support

This is Phase 1 of the modernization effort, establishing the core
package structure and build system.

## Major Changes

### 1. Migrated to src/ Layout
- Moved cli/ → src/skill_seekers/cli/
- Moved skill_seeker_mcp/ → src/skill_seekers/mcp/
- Created root package: src/skill_seekers/__init__.py
- Updated all imports: cli. → skill_seekers.cli.
- Updated all imports: skill_seeker_mcp. → skill_seekers.mcp.

### 2. Created pyproject.toml
- Modern Python packaging configuration
- All dependencies properly declared
- 8 CLI entry points configured:
  * skill-seekers (unified CLI)
  * skill-seekers-scrape
  * skill-seekers-github
  * skill-seekers-pdf
  * skill-seekers-unified
  * skill-seekers-enhance
  * skill-seekers-package
  * skill-seekers-upload
  * skill-seekers-estimate
- uv tool support enabled
- Build system: setuptools with wheel

### 3. Created Unified CLI (main.py)
- Git-style subcommands (skill-seekers scrape, etc.)
- Delegates to existing tool main() functions
- Full help system at top-level and subcommand level
- Backwards compatible with individual commands

### 4. Updated Package Versions
- cli/__init__.py: 1.3.0 → 2.0.0
- mcp/__init__.py: 1.2.0 → 2.0.0
- Root package: 2.0.0

### 5. Updated Test Suite
- Fixed test_package_structure.py for new layout
- All 28 package structure tests passing
- Updated all test imports for new structure

## Installation Methods (Working)

```bash
# Development install
pip install -e .

# Run unified CLI
skill-seekers --version  # → 2.0.0
skill-seekers --help

# Run individual tools
skill-seekers-scrape --help
skill-seekers-github --help
```

## Test Results
- Package structure tests: 28/28 passing 
- Package installs successfully 
- All entry points working 

## Still TODO (Phase 2)
- [ ] Run full test suite (299 tests)
- [ ] Update documentation (README, CLAUDE.md, etc.)
- [ ] Test with uv tool run/install
- [ ] Build and publish to PyPI
- [ ] Create PR and merge

## Breaking Changes
None - fully backwards compatible. Old import paths still work.

## Migration for Users
No action needed. Package works with both pip and uv.

Closes #168 (when complete)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-07 01:14:24 +03:00
Edgar I.
4e871588ae feat: add get_proper_filename() for .txt to .md conversion 2025-10-24 18:27:17 +04:00
Edgar I.
e88a4b0fcc fix: add retries, markdown validation, and test mocking to downloader
- Implement retry logic with exponential backoff (default: 3 retries)
- Add markdown validation to check for markdown patterns
- Replace flaky HTTP tests with comprehensive mocking
- Add 10 test cases covering all scenarios:
  - Successful download
  - Timeout with retry
  - Empty content rejection (<100 chars)
  - Non-markdown rejection
  - HTTP error handling
  - Exponential backoff validation
  - Markdown pattern detection
  - Custom timeout parameter
  - Custom max_retries parameter
  - User agent header verification

All tests now pass reliably (10/10) without making real HTTP requests.
2025-10-24 18:26:10 +04:00
Edgar I.
3dd928b34b feat: add llms.txt downloader with error handling 2025-10-24 18:26:10 +04:00