firefrost-gaming/skill-seekers-reference
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
304 Commits 1 Branch 0 Tags
52cf99136a47d000ef73045e1f3c0c3671bc69ef
Commit Graph

2 Commits

Author SHA1 Message Date
yusyus
9142223cdd refactor: Make force mode DEFAULT ON with --no-force flag to disable 
BREAKING CHANGE: Force mode is now ON by default (was OFF by default)

User requested: "make this default on with skip flag only"

Changes:
--------
- Force mode is now ON by default (skip all confirmations)
- New flag: `--no-force` to disable force mode (enable confirmations)
- Old flag: `--force` removed (force is always ON now)

Rationale:
----------
- Maximizes automation out-of-the-box
- Better UX for CI/CD and batch processing (no extra flags needed)
- Aligns with "dangerously skip mode" user request
- Explicit opt-out is better than hidden opt-in for automation tools

Migration:
----------
- Before: `skill-seekers enhance output/react/ --force`
- After: `skill-seekers enhance output/react/` (force ON by default!)
- To disable: `skill-seekers enhance output/react/ --no-force`

Behavior:
---------
- Default: `LocalSkillEnhancer(skill_dir, force=True)`
- With --no-force: `LocalSkillEnhancer(skill_dir, force=False)`

CLI Examples:
-------------
# Force ON (default - no flag needed)
skill-seekers enhance output/react/

# Force OFF (enable confirmations)
skill-seekers enhance output/react/ --no-force

# Background with force (force already ON by default)
skill-seekers enhance output/react/ --background

# Background without force (need --no-force)
skill-seekers enhance output/react/ --background --no-force

Files Changed:
--------------
- src/skill_seekers/cli/enhance_skill_local.py
  - Changed default: force=False → force=True
  - Changed flag: --force → --no-force
  - Updated docstring
  - Updated help text

- src/skill_seekers/cli/main.py
  - Changed flag: --force → --no-force
  - Updated argument forwarding

- docs/ENHANCEMENT_MODES.md
  - Updated Force Mode section (default ON)
  - Updated examples (removed unnecessary --force flags)
  - Updated batch enhancement example
  - Updated CI/CD example

- CHANGELOG.md
  - Updated "Force Mode" description (Default ON)
  - Clarified no flag needed

Impact:
-------
- ✅ CI/CD pipelines: No extra flags needed (force ON by default)
- ✅ Batch processing: Cleaner commands
- ✅ Manual users: Use --no-force if they want confirmations
- ✅ Backward compatible: Old behavior available via --no-force

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2026-01-03 23:42:56 +03:00
yusyus
909fde6d27 feat: Enhanced LOCAL enhancement modes with background/daemon/force options 
BREAKING CHANGE: None (backward compatible - headless mode remains default)

Adds 4 execution modes for LOCAL enhancement to support different use cases:
from foreground execution to fully detached daemon processes.

New Features:
------------
- **4 Execution Modes**:
  - Headless (default): Runs in foreground, waits for completion
  - Background (--background): Runs in background thread, returns immediately
  - Daemon (--daemon): Fully detached process with nohup, survives parent exit
  - Terminal (--interactive-enhancement): Opens new terminal window (existing)

- **Force Mode (--force/-f)**: Skip all confirmations for automation
  - "Dangerously skip mode" requested by user
  - Perfect for CI/CD pipelines and unattended execution
  - Works with all modes: headless, background, daemon

- **Status Monitoring**:
  - New `enhance-status` command for background/daemon processes
  - Real-time watch mode (--watch)
  - JSON output for scripting (--json)
  - Status file: .enhancement_status.json (status, progress, PID, errors)

- **Daemon Features**:
  - Fully detached process using nohup
  - Survives parent process exit, logout, SSH disconnection
  - Logging to .enhancement_daemon.log
  - PID tracking in status file

Implementation Details:
-----------------------
- Status file format: JSON with status, message, progress (0.0-1.0), timestamp, PID, errors
- Background mode: Python threading with daemon threads
- Daemon mode: subprocess.Popen with nohup and start_new_session=True
- Exit codes: 0 = success, 1 = failed, 2 = no status found

CLI Integration:
----------------
- skill-seekers enhance output/react/ (headless - default)
- skill-seekers enhance output/react/ --background (background thread)
- skill-seekers enhance output/react/ --daemon (detached process)
- skill-seekers enhance output/react/ --force (skip confirmations)
- skill-seekers enhance-status output/react/ (check status)
- skill-seekers enhance-status output/react/ --watch (real-time)

Files Changed:
--------------
- src/skill_seekers/cli/enhance_skill_local.py (+500 lines)
  - Added background mode with threading
  - Added daemon mode with nohup
  - Added force mode support
  - Added status file management (write_status, read_status)

- src/skill_seekers/cli/enhance_status.py (NEW, 200 lines)
  - Status checking command
  - Watch mode with real-time updates
  - JSON output for scripting
  - Exit codes based on status

- src/skill_seekers/cli/main.py
  - Added enhance-status subcommand
  - Added --background, --daemon, --force flags to enhance command
  - Added argument forwarding

- pyproject.toml
  - Added enhance-status entry point

- docs/ENHANCEMENT_MODES.md (NEW, 600 lines)
  - Complete guide to all 4 modes
  - Usage examples for each mode
  - Status file format documentation
  - Advanced workflows (batch processing, CI/CD)
  - Comparison table
  - Troubleshooting guide

- CHANGELOG.md
  - Documented all new features under [Unreleased]

Use Cases:
----------
1. CI/CD Pipelines: --force for unattended execution
2. Long-running tasks: --daemon for tasks that survive logout
3. Parallel processing: --background for batch enhancement
4. Debugging: --interactive-enhancement to watch Claude Code work

Testing Recommendations:
------------------------
- Test headless mode (default behavior, should be unchanged)
- Test background mode (returns immediately, check status file)
- Test daemon mode (survives parent exit, check logs)
- Test force mode (no confirmations)
- Test enhance-status command (check, watch, json modes)
- Test timeout handling in all modes

Addresses User Request:
-----------------------
User asked for "dangeressly skipp mode that didint ask anything" and
"headless instance maybe background task" alternatives. This delivers:
- Force mode (--force): No confirmations
- Background mode: Returns immediately, runs in background
- Daemon mode: Fully detached, survives logout

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
 2026-01-03 23:15:51 +03:00