Commit Graph

5 Commits

Author SHA1 Message Date
yusyus
83b03d9f9f fix: Resolve all linting errors from ruff
Fix 145 linting errors across CLI refactor code:

Type annotation modernization (Python 3.9+):
- Replace typing.Dict with dict
- Replace typing.List with list
- Replace typing.Set with set
- Replace Optional[X] with X | None

Code quality improvements:
- Remove trailing whitespace (W291)
- Remove whitespace from blank lines (W293)
- Remove unused imports (F401)
- Use dictionary lookup instead of if-elif chains (SIM116)
- Combine nested if statements (SIM102)

Files fixed (45 files):
- src/skill_seekers/cli/arguments/*.py (10 files)
- src/skill_seekers/cli/parsers/*.py (24 files)
- src/skill_seekers/cli/presets/*.py (4 files)
- src/skill_seekers/cli/create_command.py
- src/skill_seekers/cli/source_detector.py
- src/skill_seekers/cli/github_scraper.py
- tests/test_*.py (5 test files)

All files now pass ruff linting checks.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-15 20:20:55 +03:00
yusyus
7e9b52f425 feat(cli): Add -p shortcut and improve create command help text
Implemented Kimi's feedback suggestions:

1. Added -p shortcut for --preset flag
   - Makes presets easier to use: -p quick, -p standard, -p comprehensive
   - Updated create arguments to include "-p" in flags tuple

2. Improved help text formatting
   - Simplified description to avoid excessive wrapping
   - Made examples more concise and scannable
   - Custom NoWrapFormatter for better readability
   - Reduced verbosity while maintaining clarity

Changes:
- arguments/create.py: Added "-p" to preset flags
- create_command.py: Updated epilog with NoWrapFormatter
- parsers/create_parser.py: Simplified description, override register()

User Impact:
- Faster preset usage: "skill-seekers create <src> -p quick"
- Cleaner help output
- Better UX for frequently-used preset flag

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-15 19:22:59 +03:00
yusyus
29409d0c89 fix(cli): Handle progressive help flags correctly in create command
- Use underscore prefix for help flag destinations (_help_web, etc.)
- Handle help flags in main.py argv reconstruction
- Ensures progressive disclosure works through unified CLI

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-15 18:48:43 +03:00
yusyus
f896b654e3 feat(cli): Phase 3 - Progressive disclosure with better hints and examples
Improvements:
1. **Better help text formatting:**
   - Added RawDescriptionHelpFormatter to preserve example formatting
   - Examples now display cleanly instead of being collapsed

2. **Enhanced epilog with 4 sections:**
   - Examples: Usage examples for all 5 source types
   - Source Detection: Clear rules for auto-detection
   - Need More Options?: Prominent hints for source-specific help
   - Common Workflows: Quick/standard/comprehensive presets

3. **Implemented progressive disclosure:**
   - --help-web: Shows universal + web-specific arguments
   - --help-github: Shows universal + GitHub-specific arguments
   - --help-local: Shows universal + local-specific arguments
   - --help-pdf: Shows universal + PDF-specific arguments
   - --help-advanced: Shows advanced/rare options
   - --help-all: Shows all 120+ options

4. **Improved discoverability:**
   - Default help shows 13 universal arguments (clean, focused)
   - Clear hints guide users to source-specific options
   - Examples show common patterns for each source type
   - Workflows section shows preset usage patterns

Result:
 Much clearer help text with proper formatting
 Progressive disclosure reduces cognitive load
 Easy to discover source-specific options
 Better UX for both beginners and power users
 All 46 tests passing

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-15 14:56:19 +03:00
yusyus
ba1670a220 feat: Unified create command + consolidated enhancement flags
This commit includes two major improvements:

## 1. Unified Create Command (v3.0.0 feature)
- Auto-detects source type (web, GitHub, local, PDF, config)
- Three-tier argument organization (universal, source-specific, advanced)
- Routes to existing scrapers (100% backward compatible)
- Progressive disclosure: 15 universal flags in default help

**New files:**
- src/skill_seekers/cli/source_detector.py - Auto-detection logic
- src/skill_seekers/cli/arguments/create.py - Argument definitions
- src/skill_seekers/cli/create_command.py - Main orchestrator
- src/skill_seekers/cli/parsers/create_parser.py - Parser integration

**Tests:**
- tests/test_source_detector.py (35 tests)
- tests/test_create_arguments.py (30 tests)
- tests/test_create_integration_basic.py (10 tests)

## 2. Enhanced Flag Consolidation (Phase 1)
- Consolidated 3 flags (--enhance, --enhance-local, --enhance-level) → 1 flag
- --enhance-level 0-3 with auto-detection of API vs LOCAL mode
- Default: --enhance-level 2 (balanced enhancement)

**Modified files:**
- arguments/{common,create,scrape,github,analyze}.py - Added enhance_level
- {doc_scraper,github_scraper,config_extractor,main}.py - Updated logic
- create_command.py - Uses consolidated flag

**Auto-detection:**
- If ANTHROPIC_API_KEY set → API mode
- Else → LOCAL mode (Claude Code)

## 3. PresetManager Bug Fix
- Fixed module naming conflict (presets.py vs presets/ directory)
- Moved presets.py → presets/manager.py
- Updated __init__.py exports

**Test Results:**
- All 160+ tests passing
- Zero regressions
- 100% backward compatible

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-15 14:29:19 +03:00