Commit Graph

2 Commits

Author SHA1 Message Date
yusyus
f5d4a22573 test: Add comprehensive test coverage for exclude_dirs feature
Adds 7 additional test cases for Issue #203 configurable EXCLUDED_DIRS:

Test Coverage Additions:
- Local repository integration (2 tests)
  * exclude_dirs with local_repo_path
  * Replace mode with local_repo_path

- Logging verification (3 tests)
  * INFO level for extend mode
  * WARNING level for replace mode
  * No logging for default mode

- Type handling (2 tests)
  * Tuple support for exclude_dirs
  * Set support for exclude_dirs_additional

Total Test Coverage:
- 19 tests for exclude_dirs feature (all passing)
- 427 total tests passing (up from 420)
- 54% code coverage for github_scraper.py

All tests pass with no failures. 32 skipped tests are expected:
- 3 macOS-specific tests (platform limitation)
- 29 MCP tests (pass individually, skip in full suite due to pytest quirk)

Closes #203
2025-11-30 00:13:49 +03:00
yusyus
ea289cebe1 feat: Make EXCLUDED_DIRS configurable for local repository analysis
Closes #203

Adds configuration options to customize directory exclusions during local
repository analysis, while maintaining backward compatibility with smart
defaults.

**New Config Options:**

1. `exclude_dirs_additional` - Extend defaults (most common)
   - Adds custom directories to default exclusions
   - Example: ["proprietary", "legacy", "third_party"]
   - Total exclusions = defaults + additional

2. `exclude_dirs` - Replace defaults (advanced users)
   - Completely overrides default exclusions
   - Example: ["node_modules", ".git", "custom_vendor"]
   - Gives full control over exclusions

**Implementation:**

- Modified GitHubScraper.__init__() to parse exclude_dirs config
- Changed should_exclude_dir() to use instance variable instead of global
- Added logging for custom exclusions (INFO for extend, WARNING for replace)
- Maintains backward compatibility (no config = use defaults)

**Testing:**

- Added 12 comprehensive tests in test_excluded_dirs_config.py
  - 3 tests for defaults (backward compatibility)
  - 3 tests for extend mode
  - 3 tests for replace mode
  - 1 test for precedence
  - 2 tests for edge cases
- All 12 new tests passing 
- All 22 existing github_scraper tests passing 

**Documentation:**

- Updated CLAUDE.md config parameters section
- Added detailed "Configurable Directory Exclusions" feature section
- Included examples for both modes
- Listed common use cases (monorepos, enterprise, legacy codebases)

**Use Cases:**

- Monorepos with custom directory structures
- Enterprise projects with non-standard naming conventions
- Including unusual directories for analysis
- Minimal exclusions for small/simple projects

**Backward Compatibility:**

 Fully backward compatible - existing configs work unchanged
 Smart defaults maintained when no config provided
 All existing tests pass

Co-authored-by: jimmy058910 <jimmy058910@users.noreply.github.com>
2025-11-29 23:53:27 +03:00