yusyus
cee3fcf025
fix(A1.3): Add comprehensive validation to submit_config MCP tool
...
Issue: #11 (A1.3 - Add MCP tool to submit custom configs)
## Summary
Fixed submit_config MCP tool to use ConfigValidator for comprehensive validation
instead of basic 3-field checks. Now supports both legacy and unified config
formats with detailed error messages and validation warnings.
## Critical Gaps Fixed (6 total)
1. ✅ Missing comprehensive validation (HIGH) - Only checked 3 fields
2. ✅ No unified config support (HIGH) - Couldn't handle multi-source configs
3. ✅ No test coverage (MEDIUM) - Zero tests for submit_config_tool
4. ✅ No URL format validation (MEDIUM) - Accepted malformed URLs
5. ✅ No warnings for unlimited scraping (LOW) - Silent config issues
6. ✅ No url_patterns validation (MEDIUM) - No selector structure checks
## Changes Made
### Phase 1: Validation Logic (server.py lines 1224-1380)
- Added ConfigValidator import with graceful degradation
- Replaced basic validation (3 fields) with comprehensive ConfigValidator.validate()
- Enhanced category detection for unified multi-source configs
- Added validation warnings collection (unlimited scraping, missing max_pages)
- Updated GitHub issue template with:
* Config format type (Unified vs Legacy)
* Validation warnings section
* Updated documentation URL handling for unified configs
* Checklist showing "Config validated with ConfigValidator"
### Phase 2: Test Coverage (test_mcp_server.py lines 617-769)
Added 8 comprehensive test cases:
1. test_submit_config_requires_token - GitHub token requirement
2. test_submit_config_validates_required_fields - Required field validation
3. test_submit_config_validates_name_format - Name format validation
4. test_submit_config_validates_url_format - URL format validation
5. test_submit_config_accepts_legacy_format - Legacy config acceptance
6. test_submit_config_accepts_unified_format - Unified config acceptance
7. test_submit_config_from_file_path - File path input support
8. test_submit_config_detects_category - Category auto-detection
### Phase 3: Documentation Updates
- Updated Issue #11 with completion notes
- Updated tool description to mention format support
- Updated CHANGELOG.md with fix details
- Added EVOLUTION_ANALYSIS.md for deep architecture analysis
## Validation Improvements
### Before:
```python
required_fields = ["name", "description", "base_url"]
missing_fields = [field for field in required_fields if field not in config_data]
if missing_fields:
return error
```
### After:
```python
validator = ConfigValidator(config_data)
validator.validate() # Comprehensive validation:
# - Name format (alphanumeric, hyphens, underscores only)
# - URL formats (must start with http:// or https://)
# - Selectors structure (dict with proper keys)
# - Rate limits (non-negative numbers)
# - Max pages (positive integer or -1)
# - Supports both legacy AND unified formats
# - Provides detailed error messages with examples
```
## Test Results
✅ All 427 tests passing (no regressions)
✅ 8 new tests for submit_config_tool
✅ No breaking changes
## Files Modified
- src/skill_seekers/mcp/server.py (157 lines changed)
- tests/test_mcp_server.py (157 lines added)
- CHANGELOG.md (12 lines added)
- EVOLUTION_ANALYSIS.md (500+ lines, new file)
## Issue Resolution
Closes #11 - A1.3 now fully implemented with comprehensive validation,
test coverage, and support for both config formats.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com >
2025-12-21 18:32:20 +03:00
yusyus
018b02ba82
feat(A1.3): Add submit_config MCP tool for community submissions
...
- Add submit_config tool to MCP server (10th tool)
- Validates config JSON before submission
- Creates GitHub issue in skill-seekers-configs repo
- Auto-detects category from config name
- Requires GITHUB_TOKEN for authentication
- Returns issue URL for tracking
Features:
- Accepts config_path or config_json parameter
- Validates required fields (name, description, base_url)
- Auto-categorizes configs (web-frameworks, game-engines, devops, etc.)
- Creates formatted issue with testing notes
- Adds labels: config-submission, needs-review
Closes #11
2025-12-21 14:28:37 +03:00
yusyus
57cf835a47
feat(A1.2): Add fetch_config MCP tool
...
Implements A1.2 - Add MCP tool to download configs from API
Features:
- Download config files from api.skillseekersweb.com
- List all available configs (24 configs)
- Filter configs by category
- Download specific config by name
- Save to local configs directory
- Display config metadata (category, tags, type, source, last_updated)
- Error handling for 404 and network errors
Usage:
- List configs: fetch_config with list_available=true
- Filter by category: fetch_config with list_available=true, category='web-frameworks'
- Download config: fetch_config with config_name='react'
- Custom destination: fetch_config with config_name='react', destination='my_configs/'
Technical:
- Uses httpx AsyncClient for HTTP requests
- Connects to https://api.skillseekersweb.com
- Returns formatted TextContent responses
- Supports GET /api/configs and GET /api/download endpoints
- Proper error handling for HTTP and JSON errors
Tests:
- ✅ List all configs (24 total)
- ✅ List by category filter (12 web-frameworks)
- ✅ Download specific config (react.json)
- ✅ Handle nonexistent config (404 error)
Issue: N/A (from roadmap task A1.2)
2025-11-30 19:21:18 +03:00
yusyus
998be0d2dd
fix: Update setup_mcp.sh for v2.0.0 src/ layout + test fixes ( #201 )
...
Merges setup_mcp.sh fix for v2.0.0 src/ layout + test updates.
Original fix by @501981732 in PR #197 .
Test updates to make CI pass.
Closes #192
2025-11-29 21:34:51 +03:00
yusyus
ce1c07b437
feat: Add modern Python packaging - Phase 1 (Foundation)
...
Implements issue #168 - Modern Python packaging with uv support
This is Phase 1 of the modernization effort, establishing the core
package structure and build system.
## Major Changes
### 1. Migrated to src/ Layout
- Moved cli/ → src/skill_seekers/cli/
- Moved skill_seeker_mcp/ → src/skill_seekers/mcp/
- Created root package: src/skill_seekers/__init__.py
- Updated all imports: cli. → skill_seekers.cli.
- Updated all imports: skill_seeker_mcp. → skill_seekers.mcp.
### 2. Created pyproject.toml
- Modern Python packaging configuration
- All dependencies properly declared
- 8 CLI entry points configured:
* skill-seekers (unified CLI)
* skill-seekers-scrape
* skill-seekers-github
* skill-seekers-pdf
* skill-seekers-unified
* skill-seekers-enhance
* skill-seekers-package
* skill-seekers-upload
* skill-seekers-estimate
- uv tool support enabled
- Build system: setuptools with wheel
### 3. Created Unified CLI (main.py)
- Git-style subcommands (skill-seekers scrape, etc.)
- Delegates to existing tool main() functions
- Full help system at top-level and subcommand level
- Backwards compatible with individual commands
### 4. Updated Package Versions
- cli/__init__.py: 1.3.0 → 2.0.0
- mcp/__init__.py: 1.2.0 → 2.0.0
- Root package: 2.0.0
### 5. Updated Test Suite
- Fixed test_package_structure.py for new layout
- All 28 package structure tests passing
- Updated all test imports for new structure
## Installation Methods (Working)
```bash
# Development install
pip install -e .
# Run unified CLI
skill-seekers --version # → 2.0.0
skill-seekers --help
# Run individual tools
skill-seekers-scrape --help
skill-seekers-github --help
```
## Test Results
- Package structure tests: 28/28 passing ✅
- Package installs successfully ✅
- All entry points working ✅
## Still TODO (Phase 2)
- [ ] Run full test suite (299 tests)
- [ ] Update documentation (README, CLAUDE.md, etc.)
- [ ] Test with uv tool run/install
- [ ] Build and publish to PyPI
- [ ] Create PR and merge
## Breaking Changes
None - fully backwards compatible. Old import paths still work.
## Migration for Users
No action needed. Package works with both pip and uv.
Closes #168 (when complete)
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-11-07 01:14:24 +03:00
