firefrost-gaming/skill-seekers-reference
3
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
190 Commits 1 Branch 0 Tags
df78aae51f263e4a2ba7fafc4ab4ecc537321eee
Commit Graph

6 Commits

Author SHA1 Message Date
yusyus
998be0d2dd fix: Update setup_mcp.sh for v2.0.0 src/ layout + test fixes (#201) 
Merges setup_mcp.sh fix for v2.0.0 src/ layout + test updates.

Original fix by @501981732 in PR #197.
Test updates to make CI pass.

Closes #192
 2025-11-29 21:34:51 +03:00
yusyus
4ddc4cf1f3 improve: Prompt for venv creation before system install fallback 
**Context:**
PR #163 fixed critical venv detection bugs but used aggressive
--break-system-packages flag as immediate fallback.

**Improvement:**
Now when no venv is found, the script:
1. Warns user about missing virtual environment
2. Offers to create one automatically (y/n prompt)
3. If yes: Creates venv, activates it, proceeds safely
4. If creation fails: Falls back to system install with warning
5. If no: Proceeds with system install but shows clear warning

**Benefits:**
- Encourages best practices (venv usage)
- Less aggressive about bypassing system protections
- Still supports system install when needed
- Better user experience with clear choices

**Backward Compatibility:**
- All three original scenarios still work
- Only adds new prompt in "no venv" scenario
- Default behavior unchanged for existing venv users

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-11-06 23:48:07 +03:00
Hafez
fd679e2298 fix: fix setup_mcp.sh to detect and use virtual environments (#163) 
## ✅ Merged - All Bugs Fixed

Excellent work fixing both critical bugs from the initial review! All 390 tests passing.

**Original bugs fixed:**
- ✅ Double "install" command issue resolved
- ✅ pytest line now uses $PIP_INSTALL_CMD

**What's merged:**
- Virtual environment detection (active venv)
- Auto-activation of inactive venv/
- System install fallback with --user --break-system-packages

**Next:** Will add refinements to the system install fallback in a follow-up commit.

🤖 Merged with [Claude Code](https://claude.com/claude-code)
 2025-11-06 23:46:36 +03:00
yusyus
d59f5867a8 Fix setup_mcp.sh path issues (Issue #157) 
Fixed all incorrect path references in setup_mcp.sh script.

## Issue:
setup_mcp.sh was using incorrect paths (mcp/ instead of skill_seeker_mcp/), causing:
- ERROR: Could not open requirements file: 'mcp/requirements.txt'
- Configuration pointing to non-existent mcp/server.py
- All path validations failing

## Root Cause:
The MCP server was renamed from 'mcp/' to 'skill_seeker_mcp/' but setup_mcp.sh wasn't updated to reflect the new directory structure.

## Fix:
Updated all path references throughout setup_mcp.sh:

1. **Line 44**: mcp/requirements.txt → skill_seeker_mcp/requirements.txt
2. **Line 63**: mcp/server.py → skill_seeker_mcp/server.py
3. **Line 113**: $REPO_PATH/mcp/server.py → $REPO_PATH/skill_seeker_mcp/server.py
4. **Line 154**: $REPO_PATH/mcp/server.py → $REPO_PATH/skill_seeker_mcp/server.py
5. **Line 169-170**: Verification paths updated
6. **Line 232**: Test command updated

## Changes:

**Before:**
```bash
pip3 install -r mcp/requirements.txt              # ❌ File not found
timeout 3 python3 mcp/server.py                   # ❌ File not found
"$REPO_PATH/mcp/server.py"                        # ❌ Wrong path
python3 mcp/server.py                             # ❌ Wrong command
```

**After:**
```bash
pip3 install -r skill_seeker_mcp/requirements.txt  # ✅ Correct
timeout 3 python3 skill_seeker_mcp/server.py       # ✅ Correct
"$REPO_PATH/skill_seeker_mcp/server.py"            # ✅ Correct
python3 skill_seeker_mcp/server.py                 # ✅ Correct
```

## Verification:
- ✅ Script syntax validated (bash -n)
- ✅ All 6 path references updated
- ✅ File exists at skill_seeker_mcp/requirements.txt
- ✅ File exists at skill_seeker_mcp/server.py

Fixes #157

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-26 17:23:40 +03:00
yusyus
9028974da9 Fix Issue #8: Add bulletproof setup and prerequisites 
Addresses community feedback about missing setup steps.

New Documentation:
+ BULLETPROOF_QUICKSTART.md - Complete beginner guide
  - Step-by-step Python/Git installation
  - Every step with expected output
  - Troubleshooting for each step
  - Test example (5-page scrape)
  - 15-30 minute complete setup

+ TROUBLESHOOTING.md - Comprehensive troubleshooting
  - Installation issues (Python, pip, permissions)
  - Runtime issues (file not found, configs)
  - MCP setup issues (placeholder paths!)
  - Scraping issues (slow, empty content)
  - Platform-specific (macOS/Linux/Windows)
  - Verification commands

Setup Script Improvements:
✅ Fixed setup_mcp.sh path expansion
  - Now shows ACTUAL paths (not $REPO_PATH placeholder)
  - Verifies paths exist after writing config
  - Shows config contents for verification
  - Tests MCP server path validity
  - Clear warning about placeholders

README Updates:
✅ Added Prerequisites section
  - Python 3.10+ requirement clear
  - Git requirement clear
  - Links to bulletproof guide
✅ Added git clone step to Quick Start
✅ Reorganized Documentation section
  - Getting Started (new, beginner, troubleshooting)
  - Guides (advanced topics)
  - Technical (architecture)

Fixes:
- Issue #8 - Prereqs to Getting Started
- Issue #114 on project board (H1.1)
- Placeholder path problem in MCP setup
- Missing beginner-friendly docs

Impact: New users can now get started without confusion!
 2025-10-21 00:04:26 +03:00
yusyus
35499da922 Add MCP configuration and setup scripts 
Add complete setup infrastructure for MCP integration:
- example-mcp-config.json: Template Claude Code MCP configuration
- setup_mcp.sh: Automated one-command setup script
- test_mcp_server.py: Comprehensive test suite (25 tests, 100% pass)

The setup script automates:
- Dependency installation
- Configuration file generation with absolute paths
- Claude Code config directory creation
- Validation and verification

Tests cover:
- All 6 MCP tool functions
- Error handling and edge cases
- Config validation
- Page estimation
- Skill packaging

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-19 19:43:56 +03:00