Commit Graph

5 Commits

Author SHA1 Message Date
yusyus
0265de5816 style: Format all Python files with ruff
- Formatted 103 files to comply with ruff format requirements
- No code logic changes, only formatting/whitespace
- Fixes CI formatting check failures
2026-02-08 14:42:27 +03:00
yusyus
fb80c7b54f fix: Resolve deprecation warnings in Pydantic and asyncio
Fixed deprecation warnings to ensure forward compatibility:

1. Pydantic v2 Migration (embedding/models.py):
   - Migrated from class Config to model_config = ConfigDict()
   - Replaced deprecated class-based config pattern
   - Fixes PydanticDeprecatedSince20 warnings (3 occurrences)
   - Forward compatible with Pydantic v3.0

2. Asyncio Deprecation Fix (test_async_scraping.py):
   - Changed asyncio.iscoroutinefunction() to inspect.iscoroutinefunction()
   - Fixes Python 3.16 deprecation warning (2 occurrences)
   - Uses recommended inspect module API

3. Lock File Update (uv.lock):
   - Updated dependency lock file

Impact:
- Reduces test warnings from 141 to ~75
- Improves forward compatibility
- No functional changes

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-08 13:34:48 +03:00
yusyus
85dfae19f1 style: Fix remaining lint issues - down to 11 errors (98% reduction)
Fixed all critical and high-priority ruff lint issues:

Exception Chaining (B904): 39 → 0 
- Auto-fixed 29 with Python script
- Manually fixed 10 remaining cases
- Added 'from err' or 'from None' to all raise statements in except blocks

Unused Imports (F401): 5 → 0 
- Removed unused chromadb.config.Settings import
- Removed unused fastapi.responses.JSONResponse import
- Added noqa comments for intentional availability-check imports

Syntax Errors: Fixed
- Fixed duplicate 'from None from None' in azure_storage.py
- Fixed undefined 'e' in embedding_pipeline.py

Results:
- Before: 447 errors
- Fixed: 436 errors (98% reduction!)
- Remaining: 11 errors (all minor style improvements)

Remaining non-critical issues:
- 3 SIM105: Could use contextlib.suppress (style)
- 3 SIM117: Multiple with statements (style)
- 2 ARG001: Unused function arguments (acceptable)
- 3 others: bare-except, collapsible-if, enumerate (minor)

These 11 remaining are code quality suggestions, not bugs or issues.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-08 13:00:44 +03:00
yusyus
51787e57bc style: Fix 411 ruff lint issues (Kimi's issue #4)
Auto-fixed lint issues with ruff --fix and --unsafe-fixes:

Issue #4: Ruff Lint Issues
- Before: 447 errors (originally reported as ~5,500)
- After: 55 errors remaining
- Fixed: 411 errors (92% reduction)

Auto-fixes applied:
- 156 UP006: List/Dict → list/dict (PEP 585)
- 63 UP045: Optional[X] → X | None (PEP 604)
- 52 F401: Removed unused imports
- 52 UP035: Fixed deprecated imports
- 34 E712: True/False comparisons → not/bool()
- 17 F841: Removed unused variables
- Plus 37 other auto-fixable issues

Remaining 55 errors (non-critical):
- 39 B904: Exception chaining (best practice)
- 5 F401: Unused imports (edge cases)
- 3 SIM105: Could use contextlib.suppress
- 8 other minor style issues

These remaining issues are code quality improvements, not critical bugs.

Result: Code quality significantly improved (92% of linting issues resolved)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-02-08 12:46:38 +03:00
yusyus
8b3f31409e fix: Enforce min_chunk_size in RAG chunker
- Filter out chunks smaller than min_chunk_size (default 100 tokens)
- Exception: Keep all chunks if entire document is smaller than target size
- All 15 tests passing (100% pass rate)

Fixes edge case where very small chunks (e.g., 'Short.' = 6 chars) were
being created despite min_chunk_size=100 setting.

Test: pytest tests/test_rag_chunker.py -v
2026-02-07 20:59:03 +03:00