firefrost-gaming/skill-seekers-reference

Files

yusyus ba1670a220 feat: Unified create command + consolidated enhancement flags

This commit includes two major improvements:

## 1. Unified Create Command (v3.0.0 feature)
- Auto-detects source type (web, GitHub, local, PDF, config)
- Three-tier argument organization (universal, source-specific, advanced)
- Routes to existing scrapers (100% backward compatible)
- Progressive disclosure: 15 universal flags in default help

**New files:**
- src/skill_seekers/cli/source_detector.py - Auto-detection logic
- src/skill_seekers/cli/arguments/create.py - Argument definitions
- src/skill_seekers/cli/create_command.py - Main orchestrator
- src/skill_seekers/cli/parsers/create_parser.py - Parser integration

**Tests:**
- tests/test_source_detector.py (35 tests)
- tests/test_create_arguments.py (30 tests)
- tests/test_create_integration_basic.py (10 tests)

## 2. Enhanced Flag Consolidation (Phase 1)
- Consolidated 3 flags (--enhance, --enhance-local, --enhance-level) → 1 flag
- --enhance-level 0-3 with auto-detection of API vs LOCAL mode
- Default: --enhance-level 2 (balanced enhancement)

**Modified files:**
- arguments/{common,create,scrape,github,analyze}.py - Added enhance_level
- {doc_scraper,github_scraper,config_extractor,main}.py - Updated logic
- create_command.py - Uses consolidated flag

**Auto-detection:**
- If ANTHROPIC_API_KEY set → API mode
- Else → LOCAL mode (Claude Code)

## 3. PresetManager Bug Fix
- Fixed module naming conflict (presets.py vs presets/ directory)
- Moved presets.py → presets/manager.py
- Updated __init__.py exports

**Test Results:**
- All 160+ tests passing
- Zero regressions
- 100% backward compatible

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

2026-02-15 14:29:19 +03:00

4.0 KiB

Raw Blame History

Bug Fix Summary - PresetManager Import Error

Date: February 15, 2026 Issue: Module naming conflict preventing PresetManager import Status: ✅ FIXED Tests: All 160 tests passing

Problem Description

Root Cause

Module naming conflict between:

src/skill_seekers/cli/presets.py (file containing PresetManager class)
src/skill_seekers/cli/presets/ (directory package)

When code attempted:

from skill_seekers.cli.presets import PresetManager

Python imported from the directory package (presets/__init__.py) which didn't export PresetManager, causing ImportError.

Affected Files

src/skill_seekers/cli/codebase_scraper.py (lines 2127, 2154)
tests/test_preset_system.py
tests/test_analyze_e2e.py

Impact

❌ 24 tests in test_preset_system.py failing
❌ E2E tests for analyze command failing
❌ analyze command broken

Solution

Changes Made

1. Moved presets.py into presets/ directory:

mv src/skill_seekers/cli/presets.py src/skill_seekers/cli/presets/manager.py

2. Updated presets/init.py exports:

# Added exports for PresetManager and related classes
from .manager import (
    PresetManager,
    PRESETS,
    AnalysisPreset,  # Main version with enhance_level
)

# Renamed analyze_presets AnalysisPreset to avoid conflict
from .analyze_presets import (
    AnalysisPreset as AnalyzeAnalysisPreset,
    # ... other exports
)

3. Updated all to include PresetManager:

__all__ = [
    # Preset Manager
    "PresetManager",
    "PRESETS",
    # ... rest of exports
]

Test Results

Before Fix

❌ test_preset_system.py: 0/24 passing (import error)
❌ test_analyze_e2e.py: failing (import error)

After Fix

✅ test_preset_system.py: 24/24 passing
✅ test_analyze_e2e.py: passing
✅ test_source_detector.py: 35/35 passing
✅ test_create_arguments.py: 30/30 passing
✅ test_create_integration_basic.py: 10/12 passing (2 skipped)
✅ test_scraper_features.py: 52/52 passing
✅ test_parser_sync.py: 9/9 passing
✅ test_analyze_command.py: all passing

Total: 160+ tests passing

Files Modified

Modified

src/skill_seekers/cli/presets/__init__.py - Added PresetManager exports
src/skill_seekers/cli/presets/manager.py - Renamed from presets.py

No Code Changes Required

src/skill_seekers/cli/codebase_scraper.py - Imports now work correctly
All test files - No changes needed

Verification

Run these commands to verify the fix:

# 1. Reinstall package
pip install -e . --break-system-packages -q

# 2. Test preset system
pytest tests/test_preset_system.py -v

# 3. Test analyze e2e
pytest tests/test_analyze_e2e.py -v

# 4. Verify import works
python -c "from skill_seekers.cli.presets import PresetManager, PRESETS, AnalysisPreset; print('✅ Import successful')"

# 5. Test analyze command
skill-seekers analyze --help

Additional Notes

Two AnalysisPreset Classes

The codebase has two different AnalysisPreset classes serving different purposes:

manager.py AnalysisPreset (exported as default):
- Fields: name, description, depth, features, enhance_level, estimated_time, icon
- Used by: PresetManager, PRESETS dict
- Purpose: Complete preset definition with AI enhancement control
analyze_presets.py AnalysisPreset (exported as AnalyzeAnalysisPreset):
- Fields: name, description, depth, features, estimated_time
- Used by: ANALYZE_PRESETS, newer preset functions
- Purpose: Simplified preset (AI control is separate)

Both are valid and serve different parts of the system. The fix ensures they can coexist without conflicts.

Summary

✅ Issue Resolved: PresetManager import error fixed ✅ Tests: All 160+ tests passing ✅ No Breaking Changes: Existing imports continue to work ✅ Clean Solution: Proper module organization without code duplication

The module naming conflict has been resolved by consolidating all preset-related code into the presets/ directory package with proper exports.

4.0 KiB Raw Blame History