* fix: resolve 8 pipeline bugs found during skill quality review - Fix 0 APIs extracted from documentation by enriching summary.json with individual page file content before conflict detection - Fix all "Unknown" entries in merged_api.md by injecting dict keys as API names and falling back to AI merger field names - Fix frontmatter using raw slugs instead of config name by normalizing frontmatter after SKILL.md generation - Fix leaked absolute filesystem paths in patterns/index.md by stripping .skillseeker-cache repo clone prefixes - Fix ARCHITECTURE.md file count always showing "1 files" by counting files per language from code_analysis data - Fix YAML parse errors on GitHub Actions workflows by converting boolean keys (on: true) to strings - Fix false React/Vue.js framework detection in C# projects by filtering web frameworks based on primary language - Improve how-to guide generation by broadening workflow example filter to include setup/config examples with sufficient complexity - Fix test_git_sources_e2e failures caused by git init default branch being 'main' instead of 'master' Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address 6 review issues in ExecutionContext implementation Fixes from code review: 1. Mode resolution (#3 critical): _args_to_data no longer unconditionally overwrites mode. Only writes mode="api" when --api-key explicitly passed. Env-var-based mode detection moved to _default_data() as lowest priority. 2. Re-initialization warning (#4): initialize() now logs debug message when called a second time instead of silently returning stale instance. 3. _raw_args preserved in override (#5): temp context now copies _raw_args from parent so get_raw() works correctly inside override blocks. 4. test_local_mode_detection env cleanup (#7): test now saves/restores API key env vars to prevent failures when ANTHROPIC_API_KEY is set. 5. _load_config_file error handling (#8): wraps FileNotFoundError and JSONDecodeError with user-friendly ValueError messages. 6. Lint fixes: added logging import, fixed Generator import from collections.abc, fixed AgentClient return type annotation. Remaining P2/P3 items (documented, not blocking): - Lock TOCTOU in override() — safe on CPython, needs fix for no-GIL - get() reads _instance without lock — same CPython caveat - config_path not stored on instance - AnalysisSettings.depth not Literal constrained Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address all remaining P2/P3 review issues in ExecutionContext 1. Thread safety: get() now acquires _lock before reading _instance (#2) 2. Thread safety: override() saves/restores _initialized flag to prevent re-init during override blocks (#10) 3. Config path stored: _config_path PrivateAttr + config_path property (#6) 4. Literal validation: AnalysisSettings.depth now uses Literal["surface", "deep", "full"] — rejects invalid values (#9) 5. Test updated: test_analysis_depth_choices now expects ValidationError for invalid depth, added test_analysis_depth_valid_choices 6. Lint cleanup: removed unused imports, fixed whitespace in tests All 10 previously reported issues now resolved. 26 tests pass, lint clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore 5 truncated scrapers, migrate unified_scraper, fix context init 5 scrapers had main() truncated with "# Original main continues here..." after Kimi's migration — business logic was never connected: - html_scraper.py — restored HtmlToSkillConverter extraction + build - pptx_scraper.py — restored PptxToSkillConverter extraction + build - confluence_scraper.py — restored ConfluenceToSkillConverter with 3 modes - notion_scraper.py — restored NotionToSkillConverter with 4 sources - chat_scraper.py — restored ChatToSkillConverter extraction + build unified_scraper.py — migrated main() to context-first pattern with argv fallback Fixed context initialization chain: - main.py no longer initializes ExecutionContext (was stealing init from commands) - create_command.py now passes config_path from source_info.parsed - execution_context.py handles SourceInfo.raw_input (not raw_source) All 18 scrapers now genuinely migrated. 26 tests pass, lint clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve 7 data flow conflicts between ExecutionContext and legacy paths Critical fixes (CLI args silently lost): - unified_scraper Phase 6: reads ctx.enhancement.level instead of raw JSON when args=None (#3, #4) - unified_scraper Phase 6 agent: reads ctx.enhancement.agent instead of 3 independent env var lookups (#5) - doc_scraper._run_enhancement: uses agent_client.api_key instead of raw os.environ.get() — respects config file api_key (#1) Important fixes: - main._handle_analyze_command: populates _fake_args from ExecutionContext so --agent and --api-key aren't lost in analyze→enhance path (#6) - doc_scraper type annotations: replaced forward refs with Any to avoid F821 undefined name errors All changes include RuntimeError fallback for backward compatibility when ExecutionContext isn't initialized. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: 3 crashes + 1 stub in migrated scrapers found by deep scan 1. github_scraper.py: args.scrape_only and args.enhance_level crash when args=None (context path). Guarded with if args and getattr(). Also fixed agent fallback to read ctx.enhancement.agent. 2. codebase_scraper.py: args.output and args.skip_api_reference crash in summary block when args=None. Replaced with output_dir local var and ctx.analysis.skip_api_reference. 3. epub_scraper.py: main() was still a stub ending with "# Rest of main() continues..." — restored full extraction + build + enhancement logic using ctx values exclusively. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: complete ExecutionContext migration for remaining scrapers Kimi's Phase 4 scraper migrations + Claude's review fixes. All 18 scrapers now use context-first pattern with argv fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Phase 1 — ExecutionContext.get() always returns context (no RuntimeError) get() now returns a default context instead of raising RuntimeError when not explicitly initialized. This eliminates the need for try/except RuntimeError blocks in all 18 scrapers. Components can always call ExecutionContext.get() safely — it returns defaults if not initialized, or the explicitly initialized instance. Updated tests: test_get_returns_defaults_when_not_initialized, test_reset_clears_instance (no longer expects RuntimeError). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Phase 2a-c — remove 16 individual scraper CLI commands Removed individual scraper commands from: - COMMAND_MODULES in main.py (16 entries: scrape, github, pdf, word, epub, video, jupyter, html, openapi, asciidoc, pptx, rss, manpage, confluence, notion, chat) - pyproject.toml entry points (16 skill-seekers-<type> binaries) - parsers/__init__.py (16 parser registrations) All source types now accessed via: skill-seekers create <source> Kept: create, unified, analyze, enhance, package, upload, install, install-agent, config, doctor, and utility commands. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: create SkillConverter base class + converter registry New base interface that all 17 converters will inherit: - SkillConverter.run() — extract + build (same call for all types) - SkillConverter.extract() — override in subclass - SkillConverter.build_skill() — override in subclass - get_converter(source_type, config) — factory from registry - CONVERTER_REGISTRY — maps source type → (module, class) create_command will use get_converter() instead of _call_module(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: Grand Unification — one command, one interface, direct converters Complete the Grand Unification refactor: `skill-seekers create` is now the single entry point for all 18 source types. Individual scraper CLI commands (scrape, github, pdf, analyze, unified, etc.) are removed. ## Architecture changes - **18 SkillConverter subclasses**: Every scraper now inherits SkillConverter with extract() + build_skill() + SOURCE_TYPE. Factory via get_converter(). - **create_command.py rewritten**: _build_config() constructs config dicts from ExecutionContext for each source type. Direct converter.run() calls replace the old _build_argv() + sys.argv swap + _call_module() machinery. - **main.py simplified**: create command bypasses _reconstruct_argv entirely, calls CreateCommand(args).execute() directly. analyze/unified commands removed (create handles both via auto-detection). - **CreateParser mode="all"**: Top-level parser now accepts all 120+ flags (--browser, --max-pages, --depth, etc.) since create is the only entry. - **Centralized enhancement**: Runs once in create_command after converter, not duplicated in each scraper. - **MCP tools use converters**: 5 scraping tools call get_converter() directly instead of subprocess. Config type auto-detected from keys. - **ConfigValidator → UniSkillConfigValidator**: Renamed with backward- compat alias. - **Data flow**: AgentClient + LocalSkillEnhancer read ExecutionContext first, env vars as fallback. ## What was removed - main() from all 18 scraper files (~3400 lines) - 18 CLI commands from COMMAND_MODULES + pyproject.toml entry points - analyze + unified parsers from parser registry - _build_argv, _call_module, _SKIP_ARGS, _DEST_TO_FLAG, all _route_*() - setup_argument_parser, get_configuration, _check_deprecated_flags - Tests referencing removed commands/functions ## Net impact 51 files changed, ~6000 lines removed. 2996 tests pass, 0 failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: review fixes for Grand Unification PR - Add autouse conftest fixture to reset ExecutionContext singleton between tests - Replace hardcoded defaults in _is_explicitly_set() with parser-derived defaults - Upgrade ExecutionContext double-init log from debug to info - Use logger.exception() in SkillConverter.run() to preserve tracebacks - Fix docstring "17 types" → "18 types" in skill_converter.py - DRY up 10 copy-paste help handlers into dict + loop (~100 lines removed) - Fix 2 CI workflows still referencing removed `skill-seekers scrape` command - Remove broken pyproject.toml entry point for codebase_scraper:main Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve 12 logic/flow issues found in deep review Critical fixes: - UnifiedScraper.run(): replace sys.exit(1) with return 1, add return 0 - doc_scraper: use ExecutionContext.get() when already initialized instead of re-calling initialize() which silently discards new config - unified_scraper: define enhancement_config before try/except to prevent UnboundLocalError in LOCAL enhancement timeout read Important fixes: - override(): cleaner tuple save/restore for singleton swap - --agent without --api-key now sets mode="local" so env API key doesn't override explicit agent choice - Remove DeprecationWarning from _reconstruct_argv (fires on every non-create command in production) - Rewrite scrape_generic_tool to use get_converter() instead of subprocess calls to removed main() functions - SkillConverter.run() checks build_skill() return value, returns 1 if False - estimate_pages_tool uses -m module invocation instead of .py file path Low-priority fixes: - get_converter() raises descriptive ValueError on class name typo - test_default_values: save/clear API key env vars before asserting mode - test_get_converter_pdf: fix config key "path" → "pdf_path" 3056 passed, 4 failed (pre-existing dep version issues), 32 skipped. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: update MCP server tests to mock converter instead of subprocess scrape_docs_tool now uses get_converter() + _run_converter() in-process instead of run_subprocess_with_streaming. Update 4 TestScrapeDocsTool tests to mock the converter layer instead of the removed subprocess path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: YusufKaraaslanSpyke <yusuf@spykegames.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
245 lines
9.2 KiB
Python
245 lines
9.2 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
Tests for Preset System
|
|
|
|
Tests the formal preset system for analyze command.
|
|
"""
|
|
|
|
import pytest
|
|
from skill_seekers.cli.presets import PresetManager, PRESETS, AnalysisPreset
|
|
|
|
|
|
class TestPresetDefinitions:
|
|
"""Test preset definitions are complete and valid."""
|
|
|
|
def test_all_presets_defined(self):
|
|
"""Test that all expected presets are defined."""
|
|
assert "quick" in PRESETS
|
|
assert "standard" in PRESETS
|
|
assert "comprehensive" in PRESETS
|
|
assert len(PRESETS) == 3
|
|
|
|
def test_preset_structure(self):
|
|
"""Test that presets have correct structure."""
|
|
for name, preset in PRESETS.items():
|
|
assert isinstance(preset, AnalysisPreset)
|
|
assert preset.name
|
|
assert preset.description
|
|
assert preset.depth in ["surface", "deep", "full"]
|
|
assert isinstance(preset.features, dict)
|
|
assert 0 <= preset.enhance_level <= 3
|
|
assert preset.estimated_time
|
|
assert preset.icon
|
|
|
|
def test_quick_preset(self):
|
|
"""Test quick preset configuration."""
|
|
quick = PRESETS["quick"]
|
|
assert quick.name == "Quick"
|
|
assert quick.depth == "surface"
|
|
assert quick.enhance_level == 0
|
|
assert quick.estimated_time == "1-2 minutes"
|
|
assert quick.icon == "⚡"
|
|
# Quick should disable slow features
|
|
assert quick.features["api_reference"] # Essential
|
|
assert not quick.features["dependency_graph"] # Slow
|
|
assert not quick.features["patterns"] # Slow
|
|
assert not quick.features["test_examples"] # Slow
|
|
assert not quick.features["how_to_guides"] # Requires AI
|
|
assert quick.features["docs"] # Essential
|
|
|
|
def test_standard_preset(self):
|
|
"""Test standard preset configuration."""
|
|
standard = PRESETS["standard"]
|
|
assert standard.name == "Standard"
|
|
assert standard.depth == "deep"
|
|
assert standard.enhance_level == 1
|
|
assert standard.estimated_time == "5-10 minutes"
|
|
assert standard.icon == "🎯"
|
|
# Standard should enable core features
|
|
assert standard.features["api_reference"]
|
|
assert standard.features["dependency_graph"]
|
|
assert standard.features["patterns"]
|
|
assert standard.features["test_examples"]
|
|
assert not standard.features["how_to_guides"] # Slow
|
|
assert standard.features["config_patterns"]
|
|
assert standard.features["docs"]
|
|
|
|
def test_comprehensive_preset(self):
|
|
"""Test comprehensive preset configuration."""
|
|
comprehensive = PRESETS["comprehensive"]
|
|
assert comprehensive.name == "Comprehensive"
|
|
assert comprehensive.depth == "full"
|
|
assert comprehensive.enhance_level == 3
|
|
assert comprehensive.estimated_time == "20-60 minutes"
|
|
assert comprehensive.icon == "🚀"
|
|
# Comprehensive should enable ALL features
|
|
assert all(comprehensive.features.values())
|
|
|
|
|
|
class TestPresetManager:
|
|
"""Test PresetManager functionality."""
|
|
|
|
def test_get_preset(self):
|
|
"""Test PresetManager.get_preset()."""
|
|
quick = PresetManager.get_preset("quick")
|
|
assert quick is not None
|
|
assert quick.name == "Quick"
|
|
assert quick.depth == "surface"
|
|
|
|
# Case insensitive
|
|
standard = PresetManager.get_preset("STANDARD")
|
|
assert standard is not None
|
|
assert standard.name == "Standard"
|
|
|
|
def test_get_preset_invalid(self):
|
|
"""Test PresetManager.get_preset() with invalid name."""
|
|
invalid = PresetManager.get_preset("nonexistent")
|
|
assert invalid is None
|
|
|
|
def test_list_presets(self):
|
|
"""Test PresetManager.list_presets()."""
|
|
presets = PresetManager.list_presets()
|
|
assert len(presets) == 3
|
|
assert "quick" in presets
|
|
assert "standard" in presets
|
|
assert "comprehensive" in presets
|
|
|
|
def test_format_preset_help(self):
|
|
"""Test PresetManager.format_preset_help()."""
|
|
help_text = PresetManager.format_preset_help()
|
|
assert "Available presets:" in help_text
|
|
assert "⚡ quick" in help_text
|
|
assert "🎯 standard" in help_text
|
|
assert "🚀 comprehensive" in help_text
|
|
assert "1-2 minutes" in help_text
|
|
assert "5-10 minutes" in help_text
|
|
assert "20-60 minutes" in help_text
|
|
|
|
def test_get_default_preset(self):
|
|
"""Test PresetManager.get_default_preset()."""
|
|
default = PresetManager.get_default_preset()
|
|
assert default == "standard"
|
|
|
|
|
|
class TestPresetApplication:
|
|
"""Test preset application logic."""
|
|
|
|
def test_apply_preset_quick(self):
|
|
"""Test applying quick preset."""
|
|
args = {"directory": "/tmp/test"}
|
|
updated = PresetManager.apply_preset("quick", args)
|
|
|
|
assert updated["depth"] == "surface"
|
|
assert updated["enhance_level"] == 0
|
|
assert updated["skip_patterns"] # Quick disables patterns
|
|
assert updated["skip_dependency_graph"] # Quick disables dep graph
|
|
assert updated["skip_test_examples"] # Quick disables tests
|
|
assert updated["skip_how_to_guides"] # Quick disables guides
|
|
assert not updated["skip_api_reference"] # Quick enables API ref
|
|
assert not updated["skip_docs"] # Quick enables docs
|
|
|
|
def test_apply_preset_standard(self):
|
|
"""Test applying standard preset."""
|
|
args = {"directory": "/tmp/test"}
|
|
updated = PresetManager.apply_preset("standard", args)
|
|
|
|
assert updated["depth"] == "deep"
|
|
assert updated["enhance_level"] == 1
|
|
assert not updated["skip_patterns"] # Standard enables patterns
|
|
assert not updated["skip_dependency_graph"] # Standard enables dep graph
|
|
assert not updated["skip_test_examples"] # Standard enables tests
|
|
assert updated["skip_how_to_guides"] # Standard disables guides (slow)
|
|
assert not updated["skip_api_reference"] # Standard enables API ref
|
|
assert not updated["skip_docs"] # Standard enables docs
|
|
|
|
def test_apply_preset_comprehensive(self):
|
|
"""Test applying comprehensive preset."""
|
|
args = {"directory": "/tmp/test"}
|
|
updated = PresetManager.apply_preset("comprehensive", args)
|
|
|
|
assert updated["depth"] == "full"
|
|
assert updated["enhance_level"] == 3
|
|
# Comprehensive enables ALL features
|
|
assert not updated["skip_patterns"]
|
|
assert not updated["skip_dependency_graph"]
|
|
assert not updated["skip_test_examples"]
|
|
assert not updated["skip_how_to_guides"]
|
|
assert not updated["skip_api_reference"]
|
|
assert not updated["skip_config_patterns"]
|
|
assert not updated["skip_docs"]
|
|
|
|
def test_cli_overrides_preset(self):
|
|
"""Test that CLI args override preset defaults."""
|
|
args = {
|
|
"directory": "/tmp/test",
|
|
"enhance_level": 2, # Override preset default
|
|
"skip_patterns": False, # Override preset default
|
|
}
|
|
|
|
updated = PresetManager.apply_preset("quick", args)
|
|
|
|
# Preset says enhance_level=0, but CLI said 2
|
|
assert updated["enhance_level"] == 2 # CLI wins
|
|
|
|
# Preset says skip_patterns=True (disabled), but CLI said False (enabled)
|
|
assert not updated["skip_patterns"] # CLI wins
|
|
|
|
def test_apply_preset_preserves_args(self):
|
|
"""Test that apply_preset preserves existing args."""
|
|
args = {
|
|
"directory": "/tmp/test",
|
|
"output": "custom_output/",
|
|
"languages": "Python,JavaScript",
|
|
}
|
|
|
|
updated = PresetManager.apply_preset("standard", args)
|
|
|
|
# Existing args should be preserved
|
|
assert updated["directory"] == "/tmp/test"
|
|
assert updated["output"] == "custom_output/"
|
|
assert updated["languages"] == "Python,JavaScript"
|
|
|
|
def test_apply_preset_invalid(self):
|
|
"""Test applying invalid preset raises error."""
|
|
args = {"directory": "/tmp/test"}
|
|
|
|
with pytest.raises(ValueError, match="Unknown preset: nonexistent"):
|
|
PresetManager.apply_preset("nonexistent", args)
|
|
|
|
|
|
class TestBackwardCompatibility:
|
|
"""Test backward compatibility with old flags."""
|
|
|
|
def test_old_flags_still_work(self):
|
|
"""Test that old flags still work (with warnings)."""
|
|
# --quick flag
|
|
args = {"quick": True}
|
|
updated = PresetManager.apply_preset("quick", args)
|
|
assert updated["depth"] == "surface"
|
|
|
|
# --comprehensive flag
|
|
args = {"comprehensive": True}
|
|
updated = PresetManager.apply_preset("comprehensive", args)
|
|
assert updated["depth"] == "full"
|
|
|
|
def test_preset_flag_preferred(self):
|
|
"""Test that --preset flag is the recommended way."""
|
|
# Using --preset quick
|
|
args = {"preset": "quick"}
|
|
updated = PresetManager.apply_preset("quick", args)
|
|
assert updated["depth"] == "surface"
|
|
|
|
# Using --preset standard
|
|
args = {"preset": "standard"}
|
|
updated = PresetManager.apply_preset("standard", args)
|
|
assert updated["depth"] == "deep"
|
|
|
|
# Using --preset comprehensive
|
|
args = {"preset": "comprehensive"}
|
|
updated = PresetManager.apply_preset("comprehensive", args)
|
|
assert updated["depth"] == "full"
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v"])
|