fix: address review — fail on unknown/error verdicts, capture exit code, add engineering-team paths

- catch-all (*) in verdict case now sets OVERALL_EXIT=1 so auditor
  crashes/errors block merge instead of silently passing
- replace '|| true' with '&& EXIT_CODE=$? || EXIT_CODE=$?' to
  correctly capture auditor exit code
- add 'engineering-team/**' to workflow trigger paths (38 skills)
This commit is contained in:
voidborne-d
2026-03-10 11:06:19 +00:00
parent cc3dfc877a
commit ad727f1864

View File

@@ -6,6 +6,7 @@ name: Skill Security Audit
types: [opened, synchronize, reopened]
paths:
- 'engineering/**'
- 'engineering-team/**'
- 'business-growth/**'
- 'c-level-advisor/**'
- 'documentation/**'
@@ -120,8 +121,7 @@ jobs:
echo "Scanning: $skill_dir"
# Run auditor in strict mode with JSON output
JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) || true
EXIT_CODE=$?
JSON_OUT=$(python3 "$AUDITOR" "$skill_dir" --strict --json 2>&1) && EXIT_CODE=$? || EXIT_CODE=$?
# Try to parse JSON output
VERDICT=$(echo "$JSON_OUT" | python3 -c "
@@ -145,7 +145,7 @@ jobs:
PASS) ICON="✅" ;;
WARN) ICON="⚠️" ;;
FAIL) ICON="❌"; OVERALL_EXIT=1 ;;
*) ICON="❓" ;;
*) ICON="❓"; OVERALL_EXIT=1 ;;
esac
echo "### $ICON \`$skill_dir\` — $V" >> "$REPORT_FILE"