## Problem
Framework detection was broken because files with only imports (no
classes/functions) were excluded from analysis. The architectural pattern
detector received empty file lists, resulting in 0 frameworks detected.
## Root Cause
In codebase_scraper.py:873-881, the has_content check filtered out files
that didn't have classes, functions, or other structural elements. This
excluded simple __init__.py files that only contained import statements,
which are critical for framework detection.
## Solution (3 parts)
1. **Extract imports from Python files** (code_analyzer.py:140-178)
- Added import extraction using AST (ast.Import, ast.ImportFrom)
- Returns imports list in analysis results
- Now captures: "from flask import Flask" → ["flask"]
2. **Include import-only files** (codebase_scraper.py:873-881)
- Updated has_content check to include files with imports
- Files with imports are now included in analysis results
- Comment added: "IMPORTANT: Include files with imports for framework
detection (fixes#239)"
3. **Enhance framework detection** (architectural_pattern_detector.py:195-240)
- Extract imports from all Python files in analysis
- Check imports in addition to file paths and directory structure
- Prioritize import-based detection (high confidence)
- Require 2+ matches for path-based detection (avoid false positives)
- Added debug logging: "Collected N imports for framework detection"
## Results
**Before fix:**
- Test Flask project: 0 files analyzed, 0 frameworks detected
- Files with imports: excluded from analysis
- Framework detection: completely broken
**After fix:**
- Test Flask project: 3 files analyzed, Flask detected ✅
- Files with imports: included in analysis
- Framework detection: working correctly
- No false positives (ASP.NET, Rails, etc.)
## Testing
Added comprehensive test suite (tests/test_framework_detection.py):
- ✅ test_flask_framework_detection_from_imports
- ✅ test_files_with_imports_are_included
- ✅ test_no_false_positive_frameworks
All existing tests pass:
- ✅ 38 tests in test_codebase_scraper.py
- ✅ 54 tests in test_code_analyzer.py
- ✅ 3 new tests in test_framework_detection.py
## Impact
- Fixes issue #239 completely
- Framework detection now works for Python projects
- Import-only files (common in Python packages) are properly analyzed
- No performance impact (import extraction is fast)
- No breaking changes to existing functionality
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Problem:
The analyze command created duplicate documentation directories:
- output/skill-seekers/documentation/ (1.5MB) - Not referenced
- output/skill-seekers/references/documentation/ (1.5MB) - Referenced
This wasted 1.5MB per skill (50% duplication).
Root Cause:
_generate_references() copied directories to references/ but never
cleaned up the source directories.
Solution:
After copying each directory to references/, immediately remove the
source directory using shutil.rmtree(). SKILL.md only references
references/{target}, making the source directories redundant.
Changes:
- Add cleanup in _generate_references() after each copytree operation
- Add 2 comprehensive tests to verify no duplicate directories
- Test coverage: 38/38 tests passing in test_codebase_scraper.py
Impact:
- Saves 1.5MB per skill (documentation size varies)
- Prevents 50% duplication of all analysis output directories
- Clean, efficient disk usage
Tests Added:
- test_no_duplicate_directories_created: Verifies source cleanup
- test_no_disk_space_wasted: Verifies single copy in references/
Reported by: @yangshare via Issue #279
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive developer-focused sections to improve onboarding and
productivity:
- ⚡ Quick Command Reference: Most-used commands for instant access
- 🧪 Test Execution Strategy: Detailed guide on when to use test markers
- 🔄 Expanded CI/CD Pipeline: Complete breakdown of GitHub Actions workflow
- 🚨 Common Pitfalls & Solutions: 7 common issues with fixes
- 🎯 Where to Make Changes: File-by-file guide for common tasks
- 🐛 Debugging Tips: Comprehensive debugging guide with pytest options
Changes:
- Added 478 lines of practical developer guidance
- Enhanced 3 existing sections with more detail
- Maintained all original comprehensive architecture documentation
- File grew from 1,021 to 1,487 lines
Impact: Significantly improves developer experience by providing quick
access to essential commands, clear debugging workflows, and explicit
guidance on where to make changes for common tasks.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added comprehensive integration tests using the exact MikroORM URLs that
caused 404 errors in the original bug report.
Test Coverage (6 integration tests):
1. test_mikro_orm_urls_from_issue_277
- Tests exact URLs from the bug report
- Verifies no malformed anchor fragments in results
- Validates deduplication and correct URL transformation
2. test_no_404_causing_urls_generated
- Verifies no URLs matching the 404 error pattern are generated
- Tests all problematic patterns from the issue
3. test_deduplication_prevents_multiple_requests
- Validates that multiple anchors on same page deduplicate correctly
- Ensures bandwidth savings
4. test_md_files_with_anchors_preserved
- Tests .md files with anchors are handled correctly
- Verifies anchor stripping on .md URLs
5. test_real_scraping_scenario_no_404s
- Integration test simulating full llms.txt parsing flow
- Validates URL structure with regex patterns
6. test_issue_277_error_message_urls
- Tests the exact malformed URLs from error output
- Verifies correct URLs are generated instead
Results:
- 18/18 tests passing (12 unit + 6 integration)
- All MikroORM URLs from issue #277 handled correctly
- No 404-causing patterns generated
Related: #277
Thank you @PaawanBarach for this excellent contribution! 🎉
Adds pattern-based language detection for 7 new programming languages with comprehensive test coverage.
✅ 70 regex patterns with smart weight distribution
✅ Framework-specific patterns (Flutter, case classes, mixins)
✅ 7 new tests, all passing (30/30 total)
✅ No regressions, backward compatible
This resolves#165 and significantly expands our language support!
Thank you @rovo79 for this excellent contribution! 🎉
All requested changes have been implemented:
✅ Security validation for custom commands
✅ Comprehensive test suite (13 tests, 100% passing)
✅ Documentation updates
This feature enables users to use Claude Code, Codex CLI, Copilot CLI, OpenCode CLI, or custom agents for local enhancement. Great work!
- Ignore F541 (f-string without placeholders) - style preference
- Ignore ARG002 (unused method arguments) - often needed for interface compliance
- Ignore B007 (loop variable not used) - sometimes intentional
- Ignore I001 (import block unsorted) - handled by formatter
- Ignore SIM114 (combine if branches) - can reduce readability
These are style suggestions, not bugs. Keeps CI focused on actual errors.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Use sed to remove trailing whitespace from all lines
- Fixes all remaining ruff W293 errors
- This is a comprehensive fix to prevent further whitespace issues
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Change _walk_directory to check relative paths instead of absolute paths
- Fixes issue where SKIP_DIRS containing 'tmp' was skipping all files under /tmp/
- This was causing test failures on Ubuntu (tests use tempfile.mkdtemp() which creates under /tmp)
- Now only skips directories that are within the search directory, not in the absolute path
Fixes test_config_extractor.py failures on Ubuntu
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update version checks in test_package_structure.py from 2.8.0 to 2.9.0
- Update version check in test_cli_paths.py from 2.8.0 to 2.9.0
- Remove trailing whitespace from blank lines in code_analyzer.py (lines 1436-1504)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update version from v2.8.0 to v2.9.0
- Add signal_flow_analyzer.py to file structure and key locations
- Add comprehensive C3.10 Signal Flow Analysis documentation
- Remove duplicate C3.9 entry
- Update Recent Achievements with v2.9.0 release and C3.10 features
- Add Godot 4.x support details (GDScript, .tscn, .tres, .gdshader)
- Update C3.x series list to include C3.9 and C3.10
PROBLEM:
- Config extractor crashed on JSON files with arrays at root
- Error: "'list' object has no attribute 'items'"
- Example: save.json with [{"name": "item1"}, {"name": "item2"}]
- Only handled dict roots, not list roots
SOLUTION:
- Added type checking in _parse_json() and _parse_yaml()
- Handle three cases:
1. Dict at root: extract normally (existing behavior)
2. List at root: iterate and extract from each dict item
3. Primitive at root: skip with debug log
- List items are prefixed with [index] in nested path
CHANGES:
- config_extractor.py _parse_json(): Added isinstance checks
- config_extractor.py _parse_yaml(): Added list handling
EXAMPLE:
Before: WARNING: Error parsing save.json: 'list' object has no attribute 'items'
After: Extracts settings with paths like "[0].name", "[1].value"
IMPACT:
- No more crashes on valid JSON/YAML arrays
- Better coverage of config file variations
- Handles game save files, API responses, data arrays
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
PROBLEM:
- Progress indicator only showed every 5 batches or at completion
- When enhancing 1-4 patterns, no progress was visible
- User saw "Enhancing 1 patterns..." → "Enhanced 1 patterns" with no progress
SOLUTION:
- Modified progress condition to always show for small jobs (total < 10)
- Original: `if completed % 5 == 0 or completed == total`
- Updated: `if total < 10 or completed % 5 == 0 or completed == total`
IMPACT:
- Now shows "Progress: 1/3 batches completed" for small jobs
- Large jobs (10+) still show every 5th batch to avoid spam
- Applied to both _enhance_patterns_parallel and _enhance_examples_parallel
FILES:
- ai_enhancer.py line 301-302 (patterns)
- ai_enhancer.py line 439-440 (test examples)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
**Problem:**
Framework detection only checked analyzed source files, missing game
engine marker files like project.godot, .unity, .uproject (config files).
**Root Cause:**
_detect_frameworks() only scanned files_analysis list which contains
source code (.cs, .py, .js) but not config files.
**Solution:**
- Now scans actual directory structure using directory.iterdir()
- Checks BOTH analyzed files AND directory contents
- Game engines checked FIRST with priority (prevents false positives)
- Returns early if game engine found (avoids Unity→ASP.NET confusion)
**Test Results:**
Before: frameworks_detected: []
After: frameworks_detected: ["Godot"] ✅
Tested with: Cosmic Ideler (Godot 4.6 RC2 project)
- Correctly detects project.godot file
- No longer requires source code to have "godot" in paths
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Completes the implementation for Unity/Unreal/Godot game engine support
and adds missing "local" source type validation.
Changes:
- Add "local" to VALID_SOURCE_TYPES in config_validator.py
- Add _validate_local_source() method with full validation
- Add Unity/Unreal/Godot to FRAMEWORK_MARKERS for priority detection
- Add game engine directory exclusions to all 3 scrapers:
* Unity: Library/, Temp/, Logs/, UserSettings/, etc.
* Unreal: Intermediate/, Saved/, DerivedDataCache/
* Godot: .godot/, .import/
- Prevents scanning massive build cache directories (saves GBs + hours)
This completes all features mentioned in PR #278:
✅ Unity/Unreal/Godot framework detection with priority
✅ Pattern enhancement performance fix (grouped approach)
✅ Game engine directory exclusions
✅ Phase 5 SKILL.md AI enhancement
✅ Local source references copying
✅ "local" source type validation
✅ Config field name compatibility
✅ C# test example extraction
Tested:
- All unified config tests pass (18/18)
- All config validation tests pass (28/28)
- Ready for Unity project testing
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove hardcoded version string
- Import from skill_seekers._version instead
- Ensures single source of truth for version management
- Future version bumps only need pyproject.toml update
Major feature release with enhanced code analysis and documentation.
Features:
- C3.9: Project documentation extraction
- Granular AI enhancement control (--enhance-level 0-3)
- C# language support for test extraction
- 6-12x faster parallel LOCAL mode AI enhancement
- Auto-enhancement and LOCAL mode fallbacks
- GLM-4.7 and custom Claude-compatible API support
Bug Fixes:
- Fixed C# test extraction language errors
- Fixed config type field mismatch
- Fixed LocalSkillEnhancer import issues
- Fixed critical linter errors
Contributors:
- @xuintl - Chinese README improvements
- @Zhichang Yu - GLM-4.7 support and PDF fixes
- @YusufKaraaslanSpyke - Core features and maintenance
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Comprehensive guide for AI assistants working with the codebase
- Covers project structure, development commands, architecture patterns
- Includes testing guidelines, CI/CD info, and troubleshooting
- Documents all entry points, dependencies, and best practices
